RE: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-14 Thread Claudiu Zissulescu
m > Subject: Re: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue. > > > > On 11/12/15 10:29, Claudiu Zissulescu wrote: > > I did some testing here. For size, I used CSiBE testbench, and for speed, I > used coremark and dhrystone. Using a blockage or not, doesn't

Re: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-12 Thread Joern Wolfgang Rennecke
On 11/12/15 10:29, Claudiu Zissulescu wrote: I did some testing here. For size, I used CSiBE testbench, and for speed, I used coremark and dhrystone. Using a blockage or not, doesn't affect the size or speed figures. However, using TARGET_NO_SPECULATION_IN_DELAY_SLOTS_P hook betters the size

RE: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-11 Thread Claudiu Zissulescu
H Joern, > Or have some target hook to make it not even bother filling delay slots > speculatively; for targets that can fully unexpose the delay slot, like SH and > ARC >= ARC700, this aspect of fill_eager_delay_slots only mucks up > schedules and increases code size. I propose to solve the dwar

RE: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-10 Thread Claudiu Zissulescu
> > OTOH, the example you give also shows a much more nuanced approach to > throttling optimization: > the patch doesn't dead all epilogue scheduling, but specifically tests for the > presence of a frame related insn at the point where it could cause trouble. Actually, in my revised patch I do m

Re: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-09 Thread Joern Wolfgang Rennecke
On 09/12/15 15:34, Claudiu Zissulescu wrote: Well, it seems to me that we prefer to disable optimizations when talking about debug related information (see PR target/60598 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@208749 138bc75d-0d04-0410-961f-82ee72b054a4 commit). Actually, unwind in

RE: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-09 Thread Claudiu Zissulescu
> The main point of having rtl epilogues is to allow such optimizations. > Traditionally, we have said that at -O1, it is OK to curb optimizations for > the > sake of having programs that are saner to debug, while -O2 and above should > just optimize, and the debug info generation is just thrown i

Re: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-08 Thread Joern Wolfgang Rennecke
On 09/12/15 04:43, Joern Wolfgang Rennecke wrote: You can also consider having separate options to control optimizations that affect debugging. If leaving out epilogue cfi is what it takes to allow epilogue scheduling without the compiler crashing, then that is what should be done by default

Re: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-08 Thread Joern Wolfgang Rennecke
On 07/12/15 09:19, Claudiu Zissulescu wrote: Hi Joern, + insn = emit_insn (gen_blockage ()); Is this actually part of the patch to fix cfi generation? This instruction prevents the delay branch scheduler to speculatively use epilogue instructions to fill up the delay slots. Hence, gen

RE: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-07 Thread Claudiu Zissulescu
Hi Joern, > > + insn = emit_insn (gen_blockage ()); > > Is this actually part of the patch to fix cfi generation? This instruction prevents the delay branch scheduler to speculatively use epilogue instructions to fill up the delay slots. Hence, generating an assert during dwarf2cfi execut

Re: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-03 Thread Joern Wolfgang Rennecke
On 27/11/15 13:53, Claudiu Zissulescu wrote: @@ -2502,11 +2540,18 @@ arc_expand_epilogue (int sibcall_p) /* Restore any saved registers. */ if (frame_pointer_needed) { - rtx addr = gen_rtx_POST_INC (Pmode, stack_pointer_rtx); + insn = emit_insn (gen_blockage ());

[PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-11-27 Thread Claudiu Zissulescu
Properly emit DWARF2 related information while expanding epilogue. Remove the -m[no]-epilogue-cfi option as it is not needed any longer. This patch solves the dwarf2cfi errors observed while running dejagnu tests. Ok to commit? Claudiu gcc/ 2015-11-27 Claudiu Zissulescu * config/arc/a