Re: [PATCH][AArch64] Use intrinsics for upper saturating shift right

2020-11-09 Thread Christophe Lyon via Gcc-patches
Hi, On Thu, 5 Nov 2020 at 17:12, David Candler via Gcc-patches wrote: > > Hi Richard, > > Thanks for the feedback. > > Richard Sandiford writes: > > > diff --git a/gcc/config/aarch64/aarch64-builtins.c > > > b/gcc/config/aarch64/aarch64-builtins.c > > > index 4f33dd936c7..f93f4e29c89 100644 >

Re: [PATCH][AArch64] Use intrinsics for upper saturating shift right

2020-11-06 Thread Richard Sandiford via Gcc-patches
David Candler writes: > Hi Richard, > > Thanks for the feedback. > > Richard Sandiford writes: >> > diff --git a/gcc/config/aarch64/aarch64-builtins.c >> > b/gcc/config/aarch64/aarch64-builtins.c >> > index 4f33dd936c7..f93f4e29c89 100644 >> > --- a/gcc/config/aarch64/aarch64-builtins.c >> > +++

Re: [PATCH][AArch64] Use intrinsics for upper saturating shift right

2020-11-05 Thread David Candler via Gcc-patches
Hi Richard, Thanks for the feedback. Richard Sandiford writes: > > diff --git a/gcc/config/aarch64/aarch64-builtins.c > > b/gcc/config/aarch64/aarch64-builtins.c > > index 4f33dd936c7..f93f4e29c89 100644 > > --- a/gcc/config/aarch64/aarch64-builtins.c > > +++ b/gcc/config/aarch64/aarch64-builti

Re: [PATCH][AArch64] Use intrinsics for upper saturating shift right

2020-11-04 Thread Richard Sandiford via Gcc-patches
Thanks for the patch, looks good. David Candler writes: > diff --git a/gcc/config/aarch64/aarch64-builtins.c > b/gcc/config/aarch64/aarch64-builtins.c > index 4f33dd936c7..f93f4e29c89 100644 > --- a/gcc/config/aarch64/aarch64-builtins.c > +++ b/gcc/config/aarch64/aarch64-builtins.c > @@ -254,6 +

[PATCH][AArch64] Use intrinsics for upper saturating shift right

2020-11-03 Thread David Candler via Gcc-patches
The use of vqshrn_high_n_s32 was triggering an unneeded register move, because sqshrn2 is destructive but was declared as inline assembly in arm_neon.h. This patch implements sqshrn2 and uqshrn2 as actual intrinsics which do not trigger the unnecessary move, along with new tests to cover them. Boo