Re: [PATCH][AArch64] Simplify ashl3 expander for SHORT modes

2016-05-27 Thread James Greenhalgh
On Wed, Apr 27, 2016 at 03:10:47PM +0100, Kyrill Tkachov wrote: > Hi all, > > The ashl3 expander for QI and HI modes is needlessly obfuscated. > The 2nd operand predicate accepts nonmemory_operand but the expand code > FAILs if it's not a CONST_INT. We can just demand a const_int_operand in > the

Re: [PATCH][AArch64] Simplify ashl3 expander for SHORT modes

2016-05-19 Thread Kyrill Tkachov
Ping. Thanks, Kyrill On 11/05/16 10:01, Kyrill Tkachov wrote: Ping. https://gcc.gnu.org/ml/gcc-patches/2016-04/msg01651.html Thanks, Kyrill On 27/04/16 15:10, Kyrill Tkachov wrote: Hi all, The ashl3 expander for QI and HI modes is needlessly obfuscated. The 2nd operand predicate accepts non

Re: [PATCH][AArch64] Simplify ashl3 expander for SHORT modes

2016-05-11 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2016-04/msg01651.html Thanks, Kyrill On 27/04/16 15:10, Kyrill Tkachov wrote: Hi all, The ashl3 expander for QI and HI modes is needlessly obfuscated. The 2nd operand predicate accepts nonmemory_operand but the expand code FAILs if it's not a CONST_INT.

Re: [PATCH][AArch64] Simplify ashl3 expander for SHORT modes

2016-04-27 Thread Evandro Menezes
On 04/27/16 09:10, Kyrill Tkachov wrote: 2016-04-27 Kyrylo Tkachov * config/aarch64/aarch64.md (ashl3, SHORT modes): Use const_int_operand for operand 2 predicate. Simplify expand code as a result. LGTM -- Evandro Menezes

[PATCH][AArch64] Simplify ashl3 expander for SHORT modes

2016-04-27 Thread Kyrill Tkachov
Hi all, The ashl3 expander for QI and HI modes is needlessly obfuscated. The 2nd operand predicate accepts nonmemory_operand but the expand code FAILs if it's not a CONST_INT. We can just demand a const_int_operand in the predicate and remove the extra CONST_INT check. Looking at git blame, it s