Re: [PATCH][AArch64] PR60580: Fix frame pointer option magic

2017-10-24 Thread Wilco Dijkstra
James Greenhalgh wrote: > > This code is a mess, would macroing your magic number 2 help at all? All the > double negatives give me a massive headache! Well we really need to rename flag_omit_frame_pointer to flag_use_frame_pointer or similar (omit and emit are too similar!). That removes most dou

Re: [PATCH][AArch64] PR60580: Fix frame pointer option magic

2017-10-24 Thread James Greenhalgh
On Fri, Aug 04, 2017 at 04:46:09PM +0100, Wilco Dijkstra wrote: > To fix PR60580 simplify the logic in aarch64_override_options_after_change_1 > (). > If the frame pointer is enabled, set it to a special value that behaves > similar > to frame pointer omission. If we don't do this all leaf func

Re: [PATCH][AArch64] PR60580: Fix frame pointer option magic

2017-08-15 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 04 August 2017 16:46 To: GCC Patches; James Greenhalgh Cc: nd Subject: [PATCH][AArch64] PR60580: Fix frame pointer option magic   To fix PR60580 simplify the logic in aarch64_override_options_after_change_1 (). If the frame pointer is enabled, set it to a

[PATCH][AArch64] PR60580: Fix frame pointer option magic

2017-08-04 Thread Wilco Dijkstra
To fix PR60580 simplify the logic in aarch64_override_options_after_change_1 (). If the frame pointer is enabled, set it to a special value that behaves similar to frame pointer omission. If we don't do this all leaf functions will get a frame pointer even if flag_omit_leaf_frame_pointer is set.