Re: [PATCH][AArch64][3/14] Refactor option override code

2015-08-03 Thread James Greenhalgh
On Fri, Jul 24, 2015 at 09:21:46AM +0100, Kyrill Tkachov wrote: > > Thanks for the review, here's an updated version. > In the end, I chose to retain the use alloca (other patches in the series > are reworked to use it too). > > How's this? A nit or two from code you were moving or that got caug

Re: [PATCH][AArch64][3/14] Refactor option override code

2015-07-24 Thread Kyrill Tkachov
On 20/07/15 17:44, James Greenhalgh wrote: On Thu, Jul 16, 2015 at 04:20:37PM +0100, Kyrill Tkachov wrote: Hi all, This one is more meaty than the previous ones. It buffs up the parsing functions for the mcpu, march, mtune options, decouples them and makes them return an enum describing the

Re: [PATCH][AArch64][3/14] Refactor option override code

2015-07-20 Thread James Greenhalgh
On Thu, Jul 16, 2015 at 04:20:37PM +0100, Kyrill Tkachov wrote: > Hi all, > > This one is more meaty than the previous ones. It buffs up the parsing > functions for > the mcpu, march, mtune options, decouples them and makes them return an enum > describing > the errors that may occur. This will

[PATCH][AArch64][3/14] Refactor option override code

2015-07-16 Thread Kyrill Tkachov
Hi all, This one is more meaty than the previous ones. It buffs up the parsing functions for the mcpu, march, mtune options, decouples them and makes them return an enum describing the errors that may occur. This will allow us to use these functions in other contexts beyond aarch64_override_o