Re: [PATCH][AARCH64] Support tail indirect function call

2014-05-22 Thread Marcus Shawcroft
On 22 May 2014 14:03, Jiong Wang wrote: > gcc/testsuite > gcc.target/aarch64/tail-indirect-call_1.c: New test. That should be tail_indirect_call_1.c as requested in the previous review. Otherwise this is OK to commit. /Marcus

Re: [PATCH][AARCH64] Support tail indirect function call

2014-05-22 Thread Jiong Wang
On 21/05/14 15:44, Marcus Shawcroft wrote: Couple of comments: +typedef void FP(int); GNU style please, space before (. +void f1(FP fp, int n) { (fp)(n); } GNU style please, line breaks after void, '(' and ';'. Space between ')' an '('. Likewise in the following line. We should really follow

Re: [PATCH][AARCH64] Support tail indirect function call

2014-05-21 Thread Marcus Shawcroft
Hi, On 18 March 2014 14:13, Jiong Wang wrote: > * config/aarch64/predicates.md (aarch64_call_insn_operand): New > predicate. > * config/aarch64/constraints.md ("Ucs", "Usf"): New constraints. > * config/aarch64/aarch64.md (*sibcall_insn, *sibcall_value_insn): Adjust > for > tail

Re: [PATCH][AARCH64] Support tail indirect function call

2014-04-22 Thread Jiong Wang
^Ping... ok for stage 1? Regards, Jiong On 02/04/14 12:04, Jiong Wang wrote: ^Ping... Regards, Jiong On 18/03/14 14:13, Jiong Wang wrote: Current, indirect function call prevents tail-call optimization on AArch64. This patch adapt the fix for PR arm/19599 to AArch64. Is it ok for next st

Re: [PATCH][AARCH64] Support tail indirect function call

2014-04-02 Thread Jiong Wang
^Ping... Regards, Jiong On 18/03/14 14:13, Jiong Wang wrote: Current, indirect function call prevents tail-call optimization on AArch64. This patch adapt the fix for PR arm/19599 to AArch64. Is it ok for next stage 1? Thanks. -- Jiong gcc/ * config/aarch64/predicates.md (aarch64_cal

[PATCH][AARCH64] Support tail indirect function call

2014-03-18 Thread Jiong Wang
Current, indirect function call prevents tail-call optimization on AArch64. This patch adapt the fix for PR arm/19599 to AArch64. Is it ok for next stage 1? Thanks. -- Jiong gcc/ * config/aarch64/predicates.md (aarch64_call_insn_operand): New predicate. * config/aarch64/constraints