Re: [PATCH/coding style] clarify pointers and operators

2018-12-05 Thread Segher Boessenkool
On Wed, Dec 05, 2018 at 11:37:27AM -0600, Segher Boessenkool wrote: > On Wed, Dec 05, 2018 at 10:04:56AM +, Richard Sandiford wrote: > > Martin Sebor writes: > > > Martin suggested we update the Coding Conventions to describe > > > the expected style for function declarations with a pointer >

Re: [PATCH/coding style] clarify pointers and operators

2018-12-05 Thread Martin Sebor
On 12/5/18 3:04 AM, Richard Sandiford wrote: Thanks for doing this, Martin Sebor writes: Martin suggested we update the Coding Conventions to describe the expected style for function declarations with a pointer return types, and for overloaded operators. Below is the patch. As an aside, rega

Re: [PATCH/coding style] clarify pointers and operators

2018-12-05 Thread Segher Boessenkool
On Wed, Dec 05, 2018 at 10:04:56AM +, Richard Sandiford wrote: > Martin Sebor writes: > > Martin suggested we update the Coding Conventions to describe > > the expected style for function declarations with a pointer > > return types, and for overloaded operators. Below is the patch. > > > > A

Re: [PATCH/coding style] clarify pointers and operators

2018-12-05 Thread Richard Sandiford
Thanks for doing this, Martin Sebor writes: > Martin suggested we update the Coding Conventions to describe > the expected style for function declarations with a pointer > return types, and for overloaded operators. Below is the patch. > > As an aside, regarding the space convention in casts: a

Re: [PATCH/coding style] clarify pointers and operators

2018-11-28 Thread Martin Sebor
On 11/27/18 10:20 PM, Sandra Loosemore wrote: On 11/26/18 10:59 AM, Martin Sebor wrote: Martin suggested we update the Coding Conventions to describe the expected style for function declarations with a pointer return types, and for overloaded operators.  Below is the patch. As an aside, regardi

Re: [PATCH/coding style] clarify pointers and operators

2018-11-27 Thread Sandra Loosemore
On 11/26/18 10:59 AM, Martin Sebor wrote: Martin suggested we update the Coding Conventions to describe the expected style for function declarations with a pointer return types, and for overloaded operators.  Below is the patch. As an aside, regarding the space convention in casts: a crude grep

Re: [PATCH/coding style] clarify pointers and operators

2018-11-27 Thread Jeff Law
On 11/27/18 11:46 AM, Segher Boessenkool wrote: > On Mon, Nov 26, 2018 at 01:41:07PM -0700, Jeff Law wrote: >> On 11/26/18 10:59 AM, Martin Sebor wrote: >>> As an aside, regarding the space convention in casts: a crude >>> grep search yields about 10,000 instances of the "(type)x" kinds >>> of cast

Re: [PATCH/coding style] clarify pointers and operators

2018-11-27 Thread Segher Boessenkool
On Mon, Nov 26, 2018 at 01:41:07PM -0700, Jeff Law wrote: > On 11/26/18 10:59 AM, Martin Sebor wrote: > > As an aside, regarding the space convention in casts: a crude > > grep search yields about 10,000 instances of the "(type)x" kinds > > of casts in GCC sources and 40,000 of the preferred "(type

Re: [PATCH/coding style] clarify pointers and operators

2018-11-27 Thread Martin Sebor
On 11/27/18 5:57 AM, Jakub Jelinek wrote: On Mon, Nov 26, 2018 at 10:59:47AM -0700, Martin Sebor wrote: --- htdocs/codingconventions.html 30 Sep 2018 14:38:46 - 1.85 +++ htdocs/codingconventions.html 26 Nov 2018 17:59:21 - @@ -803,12 +803,17 @@ - x cast - (fo

Re: [PATCH/coding style] clarify pointers and operators

2018-11-27 Thread Jakub Jelinek
On Mon, Nov 26, 2018 at 10:59:47AM -0700, Martin Sebor wrote: > --- htdocs/codingconventions.html 30 Sep 2018 14:38:46 - 1.85 > +++ htdocs/codingconventions.html 26 Nov 2018 17:59:21 - > @@ -803,12 +803,17 @@ >- x > >cast > - (foo) x > - (foo)x > + (type) x > + (t

Re: [PATCH/coding style] clarify pointers and operators

2018-11-27 Thread Martin Liška
On 11/26/18 6:59 PM, Martin Sebor wrote: > Martin suggested we update the Coding Conventions to describe > the expected style for function declarations with a pointer > return types, and for overloaded operators.  Below is the patch. > > As an aside, regarding the space convention in casts: a crud

Re: [PATCH/coding style] clarify pointers and operators

2018-11-26 Thread Jeff Law
On 11/26/18 10:59 AM, Martin Sebor wrote: > Martin suggested we update the Coding Conventions to describe > the expected style for function declarations with a pointer > return types, and for overloaded operators.  Below is the patch. THanks. That's fine. > > As an aside, regarding the space con

[PATCH/coding style] clarify pointers and operators

2018-11-26 Thread Martin Sebor
Martin suggested we update the Coding Conventions to describe the expected style for function declarations with a pointer return types, and for overloaded operators. Below is the patch. As an aside, regarding the space convention in casts: a crude grep search yields about 10,000 instances of the