Re: [PATCH/RFC v2] PR68212: Improve Accounting of Block Frequencies During Loop Unrolling

2015-12-02 Thread Jeff Law
On 11/25/2015 09:18 AM, Bernd Schmidt wrote: I'm reading up on this stuff, but I'm probably still not the best person to review the actual frequency manipulation parts in this. There are a few things I can comment on, however. The first question would be, have you looked at the rebuild_frequenci

Re: [PATCH/RFC v2] PR68212: Improve Accounting of Block Frequencies During Loop Unrolling

2015-11-25 Thread Bernd Schmidt
I'm reading up on this stuff, but I'm probably still not the best person to review the actual frequency manipulation parts in this. There are a few things I can comment on, however. The first question would be, have you looked at the rebuild_frequencies code in predict.c, and whether you can r

[PATCH/RFC v2] PR68212: Improve Accounting of Block Frequencies During Loop Unrolling

2015-11-20 Thread Kelvin Nilsen
The problem addressed by this patch is that the intermediate code produced during loop unrolling has incorrect block frequencies. The erroneous block frequencies result because block frequencies are not adjusted to account for the execution contexts into which they are copied. These incorrect