Re: [PATCH/RFC] How to fix PR95440

2020-06-11 Thread Jason Merrill via Gcc-patches
On 6/10/20 4:43 PM, Iain Sandoe wrote: Hi Jason, Jason Merrill wrote: On Tue, Jun 9, 2020 at 5:04 AM Iain Sandoe wrote: /* Don't bother reversing an operator with two identical parameters. */ - else if (args->length () == 2 && (flags & LOOKUP_REVERSED)) + else if (ar

Re: [PATCH/RFC] How to fix PR95440

2020-06-10 Thread Iain Sandoe
Hi Jason, Jason Merrill wrote: > On Tue, Jun 9, 2020 at 5:04 AM Iain Sandoe wrote: > > /* Don't bother reversing an operator with two identical parameters. > */ > - else if (args->length () == 2 && (flags & LOOKUP_REVERSED)) > + else if (args && args->length () == 2 && (fl

Re: [PATCH/RFC] How to fix PR95440

2020-06-09 Thread Jason Merrill via Gcc-patches
On Tue, Jun 9, 2020 at 5:04 AM Iain Sandoe wrote: > Hi C++ folks, > > There are a number of places in the coroutine codegen where we need to > build calls to promise methods. > > Such methods can, in several cases, also be constexpr or static (or both) > which leads to the PR, > > Now the mechani

[PATCH/RFC] How to fix PR95440

2020-06-09 Thread Iain Sandoe
Hi C++ folks, There are a number of places in the coroutine codegen where we need to build calls to promise methods. Such methods can, in several cases, also be constexpr or static (or both) which leads to the PR, Now the mechanism I use is this; 1/ lookup the method in the relevant scop