Re: [PATCH/RFC] Add "User Experience Guidelines" to gccint.texi

2018-10-16 Thread Sandra Loosemore
On 10/12/2018 09:43 AM, David Malcolm wrote: Here's a proposed "User Experience Guidelines" section for our internals manual It's a mixture of proposed policy, together with notes on how to implement the recommendations. Thoughts? I think this documentation will be very helpful. I'll leave o

Re: [PATCH/RFC] Add "User Experience Guidelines" to gccint.texi

2018-10-16 Thread Jeff Law
On 10/12/18 9:43 AM, David Malcolm wrote: > Here's a proposed "User Experience Guidelines" section for our > internals manual > > It's a mixture of proposed policy, together with notes on how to > implement the recommendations. > > Thoughts? > > gcc/ChangeLog: > * Makefile.in (TEXI_GCCINT_

Re: [PATCH/RFC] Add "User Experience Guidelines" to gccint.texi

2018-10-15 Thread David Malcolm
On Sun, 2018-10-14 at 11:01 -0600, Martin Sebor wrote: > On 10/12/2018 09:43 AM, David Malcolm wrote: > > Here's a proposed "User Experience Guidelines" section for our > > internals manual > > > > It's a mixture of proposed policy, together with notes on how to > > implement the recommendations.

Re: [PATCH/RFC] Add "User Experience Guidelines" to gccint.texi

2018-10-15 Thread Richard Sandiford
Another thanks for doing this. Martin Sebor writes: > On 10/12/2018 09:43 AM, David Malcolm wrote: >> +Avoid using the @code{input_location} global, and the diagnostic functions >> +that implicitly use it - use @code{error_at} and @code{warning_at} rather >> +than @code{error} and @code{warning}.

Re: [PATCH/RFC] Add "User Experience Guidelines" to gccint.texi

2018-10-14 Thread Martin Sebor
On 10/12/2018 09:43 AM, David Malcolm wrote: Here's a proposed "User Experience Guidelines" section for our internals manual It's a mixture of proposed policy, together with notes on how to implement the recommendations. Thoughts? To improve consistency among diagnostic messages it's importan

Re: [PATCH/RFC] Add "User Experience Guidelines" to gccint.texi

2018-10-14 Thread Eric Gallager
On 10/12/18, David Malcolm wrote: > Here's a proposed "User Experience Guidelines" section for our > internals manual > > It's a mixture of proposed policy, together with notes on how to > implement the recommendations. > > Thoughts? I have no comments on the actual contents of the patch, just th

[PATCH/RFC] Add "User Experience Guidelines" to gccint.texi

2018-10-12 Thread David Malcolm
Here's a proposed "User Experience Guidelines" section for our internals manual It's a mixture of proposed policy, together with notes on how to implement the recommendations. Thoughts? gcc/ChangeLog: * Makefile.in (TEXI_GCCINT_FILES): Add ux.texi. * doc/gccint.texi: Include ux.t