Re: [PATCH/AARCH64 4/6] Implement the trap pattern

2013-12-05 Thread Marcus Shawcroft
Hi On 3 December 2013 21:24, Andrew Pinski wrote: > +(define_insn "trap" > + [(trap_if (const_int 1) (const_int 8))] > + "" > + "brk #1000") Please add a type attribute to the pattern. The type attributes are now shared between arm and aarch64 backends.You should use the type value intr

[PATCH/AARCH64 4/6] Implement the trap pattern

2013-12-03 Thread Andrew Pinski
As mentioned in http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02228.html, this implements the trap pattern according to what was decided which brk should be used. OK? Built and tested on aarch64-elf with no regressions. Also built a glibc for aarch64-linux-gnu with this patch included (LP64).