RE: [PATCH,testsuite] Skip gcc.dg/pic-2.c and gcc.dg/pie-2.c for MIPS.

2017-03-21 Thread Toma Tabacu
> > From: Matthew Fortune > > > > I think the skip is OK here. I'd like to get Catherine's opinion on > > this though too. I don't think we should change the definition of __PIC__ > > for -fPIC on MIPS as multi-got solves 'most' issues. If we start trying to > > figure out what __PIC__ should mean

RE: [PATCH,testsuite] Skip gcc.dg/pic-2.c and gcc.dg/pie-2.c for MIPS.

2017-03-20 Thread Moore, Catherine
> -Original Message- > From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] > Sent: Wednesday, March 15, 2017 11:37 AM > To: Moore, Catherine > Cc: Toma Tabacu ; gcc- > patc...@gcc.gnu.org > Subject: RE: [PATCH,testsuite] Skip gcc.dg/pic-2.c and gcc.dg/pie-2.c

RE: [PATCH,testsuite] Skip gcc.dg/pic-2.c and gcc.dg/pie-2.c for MIPS.

2017-03-15 Thread Matthew Fortune
Toma Tabacu writes: > The gcc.dg/pic-2.c and gcc.dg/pie-2.c tests are failing for MIPS targets > because __PIC__ is always set to 1 for MIPS. > > This patch makes the testsuite skip those two tests for all MIPS > targets. > > Tested with mips-mti-elf and mips-mti-linux-gnu. > > Should I have fi

[PATCH,testsuite] Skip gcc.dg/pic-2.c and gcc.dg/pie-2.c for MIPS.

2017-03-15 Thread Toma Tabacu
Hi, The gcc.dg/pic-2.c and gcc.dg/pie-2.c tests are failing for MIPS targets because __PIC__ is always set to 1 for MIPS. This patch makes the testsuite skip those two tests for all MIPS targets. Tested with mips-mti-elf and mips-mti-linux-gnu. Should I have fixed this in target-supports.exp in