On Mar 12, 2012, at 12:29 PM, William J. Schmidt wrote:
> Thanks, Rainer. Here's a revised patch. OK to commit?
Ok. Thanks.
On Mon, 2012-03-12 at 20:15 +0100, Rainer Orth wrote:
> "William J. Schmidt" writes:
>
> > OK, will do. I just copied the style of some other test cases that
> > skipped darwin, assuming that was the preferred syntax.
>
> No problem, I'll probably make a pass over the whole testsuite to remove
On Mar 12, 2012, at 11:40 AM, Rainer Orth wrote:
> Oh, I forgot: please indicate why you are skipping the test in the
> comment field, like:
>
> /* { dg-skip-if "PR tree-optimization/46728" { powerpc*-*-darwin* } } */
"-mpowerpc-gpopt unsupported" is arguably a better comment, as one can see
thi
Rainer Orth writes:
>> +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */
>
> Please omit defaults to dg-skip-if: { "*" } { "" } are unnecessary and
> make the directive harder to read.
Oh, I forgot: please indicate why you are skipping the test in the
comment field, like:
/* { dg-s
"William J. Schmidt" writes:
> Index: gcc/testsuite/gcc.target/powerpc/pr46728-13.c
> ===
> --- gcc/testsuite/gcc.target/powerpc/pr46728-13.c (revision 185247)
> +++ gcc/testsuite/gcc.target/powerpc/pr46728-13.c (working copy
Following in response to a report on PR46728. Committed as obvious.
2012-03-12 Bill Schmidt
PR tree-optimization/46728
* gcc.target/powerpc/pr46728-4.c: Skip for powerpc*-*-darwin*.
* gcc.target/powerpc/pr46728-5.c: Likewise.
* gcc.target/powerpc/pr46728-8.c: