Re: [PATCH,nvptx] Fix PR85056

2018-04-10 Thread Thomas Schwinge
Hi! On Mon, 26 Mar 2018 14:57:12 -0700, Cesar Philippidis wrote: > diff --git a/gcc/testsuite/gcc.target/nvptx/pr85056.c > b/gcc/testsuite/gcc.target/nvptx/pr85056.c > new file mode 100644 > index 000..fe7f8af856e > --- /dev/null > +++ b/gcc/testsuite/gcc.target/nvptx/pr85056.c > @@ -0,

Re: [PATCH,nvptx] Fix PR85056

2018-03-28 Thread Tom de Vries
On 03/28/2018 03:43 PM, Cesar Philippidis wrote: OK for stage4 trunk. Can I backport this patch to GCC 6 and 7? Yes please. Thanks, - Tom

Re: [PATCH,nvptx] Fix PR85056

2018-03-28 Thread Cesar Philippidis
On 03/27/2018 01:17 AM, Tom de Vries wrote: > On 03/26/2018 11:57 PM, Cesar Philippidis wrote: >> As noted in PR85056, the nvptx BE isn't declaring external arrays using >> PTX array notation. Specifically, it's emitting code that's missing the >> empty angle brackets '[]'. > > [ FYI, see https:/

Re: [PATCH,nvptx] Fix PR85056

2018-03-27 Thread Tom de Vries
On 03/26/2018 11:57 PM, Cesar Philippidis wrote: As noted in PR85056, the nvptx BE isn't declaring external arrays using PTX array notation. Specifically, it's emitting code that's missing the empty angle brackets '[]'. [ FYI, see https://en.wikipedia.org/wiki/Bracket For '[]' I find "square

[PATCH,nvptx] Fix PR85056

2018-03-26 Thread Cesar Philippidis
As noted in PR85056, the nvptx BE isn't declaring external arrays using PTX array notation. Specifically, it's emitting code that's missing the empty angle brackets '[]'. This patch corrects that problem. Tom, in contrast to my earlier patch in the PR, this patch only considers external arrays. Th