Re: [PATCH,WIP] Use functional parameters for data mappings in OpenACC child functions

2018-02-06 Thread Tom de Vries
On 12/21/2017 10:46 PM, Cesar Philippidis wrote: I've committed this patch to openacc-gcc-7-branch. diff --git a/gcc/omp-expand.c b/gcc/omp-expand.c index bf1f127d8d6..f674c74ec82 100644 --- a/gcc/omp-expand.c +++ b/gcc/omp-expand.c offloaded = is_gimple_omp_offloaded (entry_stmt);

Re: [PATCH,WIP] Use functional parameters for data mappings in OpenACC child functions

2017-12-21 Thread Jakub Jelinek
On Thu, Dec 21, 2017 at 01:46:56PM -0800, Cesar Philippidis wrote: > After thinking about this some more, I decided that it would be better > expand the offloaded function arguments into individual parameters > during omp lowering, rather than writing a separate pass later on. I > don't see too man

Re: [PATCH,WIP] Use functional parameters for data mappings in OpenACC child functions

2017-12-21 Thread Cesar Philippidis
On 12/18/2017 02:58 PM, Cesar Philippidis wrote: > Jakub, > > I'd like your thoughts on the following problem. > > One of the offloading bottlenecks with GPU acceleration in OpenACC is > the nontrivial offloaded function invocation overhead. At present, GCC > generates code to pass a struct conta

[PATCH,WIP] Use functional parameters for data mappings in OpenACC child functions

2017-12-18 Thread Cesar Philippidis
Jakub, I'd like your thoughts on the following problem. One of the offloading bottlenecks with GPU acceleration in OpenACC is the nontrivial offloaded function invocation overhead. At present, GCC generates code to pass a struct containing one field for each of the data mappings used in the OMP c