Re: [PATCH,Fortran 1/7] Fortran: make some trans* functions static

2021-10-26 Thread Tobias Burnus
On 25.10.21 00:30, Bernhard Reutner-Fischer via Fortran wrote: From: Bernhard Reutner-Fischer This makes some trans* functions static and deletes declarations of functions that either do not exist anymore like gfc_get_function_decl or that are unused like gfc_check_any_c_kind. gcc/fortran/Cha

Re: [PATCH,Fortran 1/7] Fortran: make some trans* functions static

2021-10-25 Thread Bernhard Reutner-Fischer via Gcc-patches
On Mon, 25 Oct 2021 08:43:09 +0200 Tobias Burnus wrote: > Hi Thomas, > > On 25.10.21 07:47, Thomas Koenig via Fortran wrote: > > what you're doing seems a useful clean-up, thanks. > > > > One point for discussion: > >> -match > >> +static match > >> gfc_match_label (void) > > I have genera

Re: [PATCH,Fortran 1/7] Fortran: make some trans* functions static

2021-10-24 Thread Tobias Burnus
Hi Thomas, On 25.10.21 07:47, Thomas Koenig via Fortran wrote: what you're doing seems a useful clean-up, thanks. One point for discussion: -match +static match gfc_match_label (void) I have generally understood that the gfc_ prefix is for global variables and functions only. We do not alw

Re: [PATCH,Fortran 1/7] Fortran: make some trans* functions static

2021-10-24 Thread Thomas Koenig via Gcc-patches
Hi Bernhard, what you're doing seems a useful clean-up, thanks. One point for discussion: -match +static match gfc_match_label (void) I have generally understood that the gfc_ prefix is for global variables and functions only. We do not always adhere to it (also since some global functi

[PATCH,Fortran 1/7] Fortran: make some trans* functions static

2021-10-24 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer This makes some trans* functions static and deletes declarations of functions that either do not exist anymore like gfc_get_function_decl or that are unused like gfc_check_any_c_kind. gcc/fortran/ChangeLog: * expr.c (is_non_empty_structure_constructor): Ma