Re: [PATCH, wide-int] change fixed_wide_int_storage from class to struct

2016-05-17 Thread Mike Stump
On May 15, 2016, at 1:30 PM, Andrew Pinski wrote: > > Can we recommend that clang disable this warning by default instead? No. We want to ensure the class/struct tags match as there is no good reason to have them differ. > Or use an option flag to disable the warning while compiling gcc? Don

Re: [PATCH, wide-int] change fixed_wide_int_storage from class to struct

2016-05-17 Thread Mike Stump
On May 15, 2016, at 12:03 PM, Gerald Pfeifer wrote: > While not a bug according to the language of the C++ standard, this > causes dozens of warnings when building GCC with clang, and there is > not benefit of mixing struct and class like this. > > Mike, when I had a similar case a while ago you

Re: [PATCH, wide-int] change fixed_wide_int_storage from class to struct

2016-05-15 Thread Richard Biener
On May 15, 2016 9:03:22 PM GMT+02:00, Gerald Pfeifer wrote: >While not a bug according to the language of the C++ standard, this >causes dozens of warnings when building GCC with clang, and there is >not benefit of mixing struct and class like this. > >Mike, when I had a similar case a while ago y

Re: [PATCH, wide-int] change fixed_wide_int_storage from class to struct

2016-05-15 Thread Andrew Pinski
On Sun, May 15, 2016 at 12:03 PM, Gerald Pfeifer wrote: > While not a bug according to the language of the C++ standard, this > causes dozens of warnings when building GCC with clang, and there is > not benefit of mixing struct and class like this. > > Mike, when I had a similar case a while ago y

[PATCH, wide-int] change fixed_wide_int_storage from class to struct

2016-05-15 Thread Gerald Pfeifer
While not a bug according to the language of the C++ standard, this causes dozens of warnings when building GCC with clang, and there is not benefit of mixing struct and class like this. Mike, when I had a similar case a while ago you sounded pretty supportive of this kind of change. Would you b