RE: [PATCH, testsuite] MIPS: Remove redundant dg-skip-if from mips16-attributes.c.

2016-12-14 Thread Toma Tabacu
Committed as r243649. Regards, Toma > Toma Tabacu writes: > > In the case of mips16-attributes.c, even though the (-mips16) option ensures > > that -mmicromips will be overriden, there still is a dg-skip-if for > > -mmicromips. > > > > I think that it is not necessary and it actually decreases t

RE: [PATCH, testsuite] MIPS: Remove redundant dg-skip-if from mips16-attributes.c.

2016-12-14 Thread Matthew Fortune
Toma Tabacu writes: > In the case of mips16-attributes.c, even though the (-mips16) option ensures > that -mmicromips will be overriden, there still is a dg-skip-if for > -mmicromips. > > I think that it is not necessary and it actually decreases test coverage, > because it will cause the testsu

[PATCH, testsuite] MIPS: Remove redundant dg-skip-if from mips16-attributes.c.

2016-12-14 Thread Toma Tabacu
Hi, In the case of mips16-attributes.c, even though the (-mips16) option ensures that -mmicromips will be overriden, there still is a dg-skip-if for -mmicromips. I think that it is not necessary and it actually decreases test coverage, because it will cause the testsuite to skip this test instead