Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-04 Thread Peter Bergner
On 4/4/18 2:23 PM, Richard Biener wrote: > On April 4, 2018 8:25:25 PM GMT+02:00, Peter Bergner > wrote: >>> Nobody mentioned if this was a regression or not, so I did some testing >>> and it ICEs on GCC 7 but not on GCC 6. Is it ok to back port to GCC 7 >>> assuming bootstrap and regtesting are

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-04 Thread Richard Biener
On April 4, 2018 8:25:25 PM GMT+02:00, Peter Bergner wrote: >On 4/4/18 10:43 AM, Peter Bergner wrote: >> On 4/4/18 2:15 AM, Richard Biener wrote: >>> On Tue, 3 Apr 2018, Peter Bergner wrote: >>> On 4/3/18 1:40 PM, H.J. Lu wrote: > On Tue, Apr 3, 2018 at 11:36 AM, Peter Bergner > wrote: >

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-04 Thread Peter Bergner
On 4/4/18 10:43 AM, Peter Bergner wrote: > On 4/4/18 2:15 AM, Richard Biener wrote: >> On Tue, 3 Apr 2018, Peter Bergner wrote: >> >>> On 4/3/18 1:40 PM, H.J. Lu wrote: On Tue, Apr 3, 2018 at 11:36 AM, Peter Bergner wrote: > gcc/testsuite/ > PR rtl-optimization/84878 >>>

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-04 Thread Peter Bergner
On 4/4/18 2:15 AM, Richard Biener wrote: > On Tue, 3 Apr 2018, Peter Bergner wrote: > >> On 4/3/18 1:40 PM, H.J. Lu wrote: >>> On Tue, Apr 3, 2018 at 11:36 AM, Peter Bergner wrote: gcc/testsuite/ PR rtl-optimization/84878 * gcc.dg/pr84878.c: New test. >>> >>> Wrong

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-04 Thread Richard Biener
On Tue, 3 Apr 2018, Peter Bergner wrote: > On 4/3/18 1:40 PM, H.J. Lu wrote: > > On Tue, Apr 3, 2018 at 11:36 AM, Peter Bergner wrote: > >> gcc/testsuite/ > >> PR rtl-optimization/84878 > >> * gcc.dg/pr84878.c: New test. > > > > Wrong test filename. > > Ooops, thanks for spottin

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-03 Thread Peter Bergner
On 4/3/18 1:40 PM, H.J. Lu wrote: > On Tue, Apr 3, 2018 at 11:36 AM, Peter Bergner wrote: >> gcc/testsuite/ >> PR rtl-optimization/84878 >> * gcc.dg/pr84878.c: New test. > > Wrong test filename. Ooops, thanks for spotting that! Will fix. Peter

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-03 Thread H.J. Lu
On Tue, Apr 3, 2018 at 11:36 AM, Peter Bergner wrote: > On 4/2/18 9:21 AM, Alexander Monakov wrote: >> On Tue, 27 Mar 2018, Richard Biener wrote: >>> If they only appear in the exit/entry block ignoring them should be safe. >>> >>> But who knows... >> >> Roman and I discussed a related problem a f

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-03 Thread Peter Bergner
On 4/2/18 9:21 AM, Alexander Monakov wrote: > On Tue, 27 Mar 2018, Richard Biener wrote: >> If they only appear in the exit/entry block ignoring them should be safe. >> >> But who knows... > > Roman and I discussed a related problem a few weeks ago, so here's my 2c. > As I don't have any special D

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-02 Thread Alexander Monakov
On Tue, 27 Mar 2018, Richard Biener wrote: > > > so this is kind-of global regs being live across all BBs? This sounds > > > a bit stupid to me, but well ... IMHO those refs should be at > > > specific insns like calls. > > > > > > So maybe, with a big fat comment, it is OK to ignore artificial >

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-03-27 Thread Richard Biener
On Tue, 27 Mar 2018, Peter Bergner wrote: > On 3/27/18 3:18 AM, Richard Biener wrote: > > On Mon, 26 Mar 2018, Peter Bergner wrote: > >>/* Create inter-loop true dependences and anti dependences. */ > >>for (r_use = DF_REF_CHAIN (last_def); r_use != NULL; r_use = > >> r_use->next) > >>

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-03-27 Thread Peter Bergner
On 3/27/18 3:18 AM, Richard Biener wrote: > On Mon, 26 Mar 2018, Peter Bergner wrote: >>/* Create inter-loop true dependences and anti dependences. */ >>for (r_use = DF_REF_CHAIN (last_def); r_use != NULL; r_use = r_use->next) >> { >> + /* PR84878: Some definitions of global hard

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-03-27 Thread Richard Biener
On Mon, 26 Mar 2018, Peter Bergner wrote: > PR84878 shows an example where we segv while creating data dependence edges > for SMS. > > ddg.c:add_cross_iteration_register_deps(): > > /* Create inter-loop true dependences and anti dependences. */ > for (r_use = DF_REF_CHAIN (last_def); r_use

[PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-03-26 Thread Peter Bergner
PR84878 shows an example where we segv while creating data dependence edges for SMS. ddg.c:add_cross_iteration_register_deps(): /* Create inter-loop true dependences and anti dependences. */ for (r_use = DF_REF_CHAIN (last_def); r_use != NULL; r_use = r_use->next) { rtx_insn *use_i