Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046

2018-12-12 Thread Peter Bergner
On 12/7/18 11:38 AM, Peter Bergner wrote: > On 12/4/18 4:53 PM, Segher Boessenkool wrote: >>> Since I backported the earlier fix to GCC8, I'd like to backport this >>> there too. >> >> Okay for there too. > > Great, I'll backport the changes and commit after regression testing. > Thanks! Backport

Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046

2018-12-07 Thread Peter Bergner
On 12/4/18 4:53 PM, Segher Boessenkool wrote: > Okay, so you make -mabi={ibm,ieee}longdouble be valid options only if > there is -mlong-double-128. Could you add that to the documentation then > please? Done. >> Is this ok for mainline once bootstrap and regtesting come back clean? > > Okay wi

Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046

2018-12-04 Thread Segher Boessenkool
On Tue, Dec 04, 2018 at 01:42:52PM -0600, Peter Bergner wrote: > On 11/28/18 3:27 PM, Peter Bergner wrote: > > gcc/ > > PR target/87496 > > * config/rs6000/rs6000.c (rs6000_option_override_internal): Disallow > > -mabi=ieeelongdouble without both -mpopcntd and -mvsx. > > So this "fix"

Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046

2018-12-04 Thread Peter Bergner
On 11/28/18 3:27 PM, Peter Bergner wrote: > gcc/ > PR target/87496 > * config/rs6000/rs6000.c (rs6000_option_override_internal): Disallow > -mabi=ieeelongdouble without both -mpopcntd and -mvsx. So this "fix" ended up accidentally disallowing -mabi=ibmlongdouble as well, which is

Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046

2018-11-29 Thread Peter Bergner
On 11/29/18 1:31 PM, Peter Bergner wrote: > On 11/29/18 11:26 AM, Segher Boessenkool wrote: >> On Wed, Nov 28, 2018 at 03:27:19PM -0600, Peter Bergner wrote: >>> PR87496 shows a bug where we ICE if we attempt to use -mabi=ieeelongdouble >>> and -mno-popcntd. The IEEE128 support requires full ISA 2

Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046

2018-11-29 Thread Peter Bergner
On 11/29/18 11:26 AM, Segher Boessenkool wrote: > On Wed, Nov 28, 2018 at 03:27:19PM -0600, Peter Bergner wrote: >> PR87496 shows a bug where we ICE if we attempt to use -mabi=ieeelongdouble >> and -mno-popcntd. The IEEE128 support requires full ISA 2.06 (aka POWER7) >> support, so we really shoul

Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046

2018-11-29 Thread Segher Boessenkool
On Wed, Nov 28, 2018 at 03:27:19PM -0600, Peter Bergner wrote: > PR87496 shows a bug where we ICE if we attempt to use -mabi=ieeelongdouble > and -mno-popcntd. The IEEE128 support requires full ISA 2.06 (aka POWER7) > support, so we really should throw an error when using those options > together.

Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046

2018-11-28 Thread Peter Bergner
On 11/28/18 3:27 PM, Peter Bergner wrote: > Ok for mainline once bootstrap and regtesting are complete and clean? > > Peter > > > gcc/ > PR target/87496 > * config/rs6000/rs6000.c (rs6000_option_override_internal): Disallow > -mabi=ieeelongdouble without both -mpopcntd and -mvs

[PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046

2018-11-28 Thread Peter Bergner
PR87496 shows a bug where we ICE if we attempt to use -mabi=ieeelongdouble and -mno-popcntd. The IEEE128 support requires full ISA 2.06 (aka POWER7) support, so we really should throw an error when using those options together. Ditto for -mabi=ieeelongdouble and -mno-vsx. The patch below does th