Re: [PATCH, rs6000] Enable ASAN build on powerpc*-linux

2012-12-06 Thread Peter Bergner
On Thu, 2012-12-06 at 15:29 -0500, David Edelsohn wrote: > On Thu, Dec 6, 2012 at 2:40 PM, Peter Bergner wrote: > > * config/rs6000/sysv4.h (TARGET_ASAN_SHADOW_OFFSET): Define. > > * config/rs6000/rs6000.c (rs6000_asan_shadow_offset): New function. > > * config/rs6000/rs600

Re: [PATCH, rs6000] Enable ASAN build on powerpc*-linux

2012-12-06 Thread David Edelsohn
On Thu, Dec 6, 2012 at 2:40 PM, Peter Bergner wrote: > Ok, how about the following which bootstrapped and regtested fine? > > Peter > > > libsanitizer/ > * configure.tgt: Enable build on powerpc*-linux. > > gcc/ > * config/rs6000/sysv4.h (TARGET_ASAN_SHADOW_OFFSET): Define. >

Re: [PATCH, rs6000] Enable ASAN build on powerpc*-linux

2012-12-06 Thread Peter Bergner
On Thu, 2012-12-06 at 10:50 -0500, David Edelsohn wrote: > On Thu, Dec 6, 2012 at 9:46 AM, Peter Bergner wrote: > > >> That macro determines if GCC thinks -fsanitze=address is supported, > >> which it is not on AIX. The macro probably should be defined in sysv4.h, > >> not rs6000.c, and the func

Re: [PATCH, rs6000] Enable ASAN build on powerpc*-linux

2012-12-06 Thread David Edelsohn
On Thu, Dec 6, 2012 at 9:53 AM, Jakub Jelinek wrote: > On i?86/x86_64 it is provided for all targets, but only some of the targets > build libsanitizer then. Either users get errors at compile time (missing > compiler support), or at link time (missing library support). > I think the compiler si

Re: [PATCH, rs6000] Enable ASAN build on powerpc*-linux

2012-12-06 Thread David Edelsohn
On Thu, Dec 6, 2012 at 9:46 AM, Peter Bergner wrote: >> That macro determines if GCC thinks -fsanitze=address is supported, >> which it is not on AIX. The macro probably should be defined in sysv4.h, >> not rs6000.c, and the function should not be defined appropriately. > > Ok, I can move the ma

Re: [PATCH, rs6000] Enable ASAN build on powerpc*-linux

2012-12-06 Thread Jakub Jelinek
On Thu, Dec 06, 2012 at 08:46:20AM -0600, Peter Bergner wrote: > On Thu, 2012-12-06 at 09:39 -0500, David Edelsohn wrote: > > On Wed, Dec 5, 2012 at 5:34 PM, Peter Bergner wrote: > > > * config/rs6000/rs6000.c (TARGET_ASAN_SHADOW_OFFSET): Define. > > > (rs6000_asan_shadow_offset):

Re: [PATCH, rs6000] Enable ASAN build on powerpc*-linux

2012-12-06 Thread Peter Bergner
On Thu, 2012-12-06 at 09:39 -0500, David Edelsohn wrote: > On Wed, Dec 5, 2012 at 5:34 PM, Peter Bergner wrote: > > * config/rs6000/rs6000.c (TARGET_ASAN_SHADOW_OFFSET): Define. > > (rs6000_asan_shadow_offset): New function. > > * config/rs6000/rs6000.h (FRAME_GROWS_DOWNWAR

Re: [PATCH, rs6000] Enable ASAN build on powerpc*-linux

2012-12-06 Thread David Edelsohn
On Wed, Dec 5, 2012 at 5:34 PM, Peter Bergner wrote: > Below are the port changes to enable building ASAN on powerpc*-linux. > The libsanitizer changes required for powerpc*-linux have already been > committed. This passes bootstrap and regtesting with no regressions > and we also pass the two AS

[PATCH, rs6000] Enable ASAN build on powerpc*-linux

2012-12-05 Thread Peter Bergner
Below are the port changes to enable building ASAN on powerpc*-linux. The libsanitizer changes required for powerpc*-linux have already been committed. This passes bootstrap and regtesting with no regressions and we also pass the two ASAN test suite test cases. Ok for mainline? Peter libsaniti