Re: [PATCH, rs6000] Don't convert a vector constant load into a splat illegally

2013-10-18 Thread Bill Schmidt
Just a quick note that overnight testing of the posted patch was clean. Recap: There are three options on the table: - the posted patch - that patch with the (1 - start) change - replace nunits - 1 with nunits as the loop upper bound I'm happy to implement any of them, as you prefer. I lean t

Re: [PATCH, rs6000] Don't convert a vector constant load into a splat illegally

2013-10-17 Thread Bill Schmidt
On Fri, 2013-10-18 at 00:34 -0400, David Edelsohn wrote: > On Thu, Oct 17, 2013 at 10:43 PM, Bill Schmidt > wrote: > > Hi, > > > > In little endian mode, we managed to convert a load of the V4SI vector > > {3, 3, 3, 7} into a vspltisw of 3, apparently taking offense at the > > number 7. It turn

Re: [PATCH, rs6000] Don't convert a vector constant load into a splat illegally

2013-10-17 Thread David Edelsohn
On Thu, Oct 17, 2013 at 10:43 PM, Bill Schmidt wrote: > Hi, > > In little endian mode, we managed to convert a load of the V4SI vector > {3, 3, 3, 7} into a vspltisw of 3, apparently taking offense at the > number 7. It turns out we only looked at the first N-1 elements of an > N-element vector i

[PATCH, rs6000] Don't convert a vector constant load into a splat illegally

2013-10-17 Thread Bill Schmidt
Hi, In little endian mode, we managed to convert a load of the V4SI vector {3, 3, 3, 7} into a vspltisw of 3, apparently taking offense at the number 7. It turns out we only looked at the first N-1 elements of an N-element vector in little endian mode, and verified the zeroth element twice. Adju