Re: [PATCH, rs6000] Add Power10 scheduling description

2021-03-02 Thread Segher Boessenkool
Hi! On Fri, Nov 13, 2020 at 04:04:30PM -0600, Pat Haugen wrote: > gcc/ > * config/rs6000/rs6000.c (struct processor_costs): New. Will already commented on this; please consider his comments :-) > (rs6000_option_override_internal): Set Power10 costs. > (rs6000_issue_rate): Set P

Re: [PATCH, rs6000] Add Power10 scheduling description

2021-03-02 Thread Segher Boessenkool
On Wed, Nov 18, 2020 at 03:10:21PM -0600, Pat Haugen wrote: > On 11/17/20 10:31 PM, will schmidt wrote: > >> +(define_cpu_unit "fp_div0_power10,fp_div1_power10,fp_div2_power10, > >> +fp_div3_power10" "power10div") > > > > The spacing catches my eye, I'd want to add spaces around those

Re: [PATCH, rs6000] Add Power10 scheduling description

2021-03-02 Thread Segher Boessenkool
On Tue, Nov 17, 2020 at 10:31:42PM -0600, will schmidt wrote: > > 2020-11-13 Pat Haugen > > > > gcc/ > > * config/rs6000/rs6000.c (struct processor_costs): New. > > Should that add/reference the "power10_cost" structure itself? Yup. > +;; Copyright (C) 2020-2020 Free Software Foundation,

Re: [PATCH, rs6000] Add Power10 scheduling description

2021-03-02 Thread Pat Haugen via Gcc-patches
Ping3 On 2/18/21 2:31 PM, Pat Haugen via Gcc-patches wrote: > Ping2. > > On 1/26/21 11:30 AM, Pat Haugen via Gcc-patches wrote: >> Ping. >> >> On 11/13/20 4:04 PM, Pat Haugen via Gcc-patches wrote: >>> Add Power10 scheduling description. >>> >>> This patch adds the Power10 scheduling description.

Re: [PATCH, rs6000] Add Power10 scheduling description

2021-02-18 Thread Pat Haugen via Gcc-patches
Ping2. On 1/26/21 11:30 AM, Pat Haugen via Gcc-patches wrote: > Ping. > > On 11/13/20 4:04 PM, Pat Haugen via Gcc-patches wrote: >> Add Power10 scheduling description. >> >> This patch adds the Power10 scheduling description. Since power10.md was >> pretty much a complete rewrite (existing versi

Re: [PATCH, rs6000] Add Power10 scheduling description

2021-01-26 Thread Pat Haugen via Gcc-patches
Ping. On 11/13/20 4:04 PM, Pat Haugen via Gcc-patches wrote: > Add Power10 scheduling description. > > This patch adds the Power10 scheduling description. Since power10.md was > pretty much a complete rewrite (existing version of power10.md is mostly just > a copy of power9.md), I diffed power1

Re: [PATCH, rs6000] Add Power10 scheduling description

2020-11-18 Thread Pat Haugen via Gcc-patches
On 11/17/20 10:31 PM, will schmidt wrote: > On Fri, 2020-11-13 at 16:04 -0600, Pat Haugen via Gcc-patches wrote: >> +(define_automaton "power10dsp,power10issue,power10div") >> + >> +; Decode/dispatch slots >> +(define_cpu_unit "du0_power10,du1_power10,du2_power10,du3_power10, >> + du4_

Re: [PATCH, rs6000] Add Power10 scheduling description

2020-11-17 Thread will schmidt via Gcc-patches
On Fri, 2020-11-13 at 16:04 -0600, Pat Haugen via Gcc-patches wrote: > Add Power10 scheduling description. > > This patch adds the Power10 scheduling description. Since power10.md > was pretty much a complete rewrite (existing version of power10.md is > mostly just a copy of power9.md), I diffed p

Re: [PATCH, rs6000] Add Power10 scheduling description

2020-11-17 Thread will schmidt via Gcc-patches
On Fri, 2020-11-13 at 16:04 -0600, Pat Haugen via Gcc-patches wrote: > diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c > index 4d528a39a37..85bb42d6dce 100644 > --- a/gcc/config/rs6000/rs6000.c > +++ b/gcc/config/rs6000/rs6000.c > @@ -1080,6 +1080,26 @@ struct processor_costs p

[PATCH, rs6000] Add Power10 scheduling description

2020-11-13 Thread Pat Haugen via Gcc-patches
Add Power10 scheduling description. This patch adds the Power10 scheduling description. Since power10.md was pretty much a complete rewrite (existing version of power10.md is mostly just a copy of power9.md), I diffed power10.md with /dev/null so that the full contents of the file are shown as