Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-17 Thread Mike Stump
On Jul 17, 2013, at 7:40 AM, Iain Sandoe wrote: > This series broke bootstrap on powerpc-apple-darwin9. > fixed as below, committed as obvious as r201011. Thanks.

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-17 Thread Iain Sandoe
Hi, On 16 Jul 2013, at 22:07, Peter Bergner wrote: > On Tue, 2013-07-16 at 15:31 -0400, David Edelsohn wrote: >> On Tue, Jul 16, 2013 at 3:27 PM, Peter Bergner wrote: >>> On Tue, 2013-07-16 at 11:55 -0500, Peter Bergner wrote: * config/rs6000/rs6000.h (FIRST_PSEUDO_REGISTERS): Mention

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-16 Thread Peter Bergner
On Tue, 2013-07-16 at 15:31 -0400, David Edelsohn wrote: > On Tue, Jul 16, 2013 at 3:27 PM, Peter Bergner wrote: > > On Tue, 2013-07-16 at 11:55 -0500, Peter Bergner wrote: > >> * config/rs6000/rs6000.h (FIRST_PSEUDO_REGISTERS): Mention HTM > >> registers in the comment. > >> (DW

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-16 Thread David Edelsohn
On Tue, Jul 16, 2013 at 3:27 PM, Peter Bergner wrote: > On Tue, 2013-07-16 at 11:55 -0500, Peter Bergner wrote: >> * config/rs6000/rs6000.h (FIRST_PSEUDO_REGISTERS): Mention HTM >> registers in the comment. >> (DWARF_FRAME_REGISTERS): Subtract also the 3 HTM registers. >> (

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-16 Thread Peter Bergner
On Tue, 2013-07-16 at 11:55 -0500, Peter Bergner wrote: > * config/rs6000/rs6000.h (FIRST_PSEUDO_REGISTERS): Mention HTM > registers in the comment. > (DWARF_FRAME_REGISTERS): Subtract also the 3 HTM registers. > (DWARF_REG_TO_UNWIND_COLUMN): Use DWARF_FRAME_REGISTERS >

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-16 Thread Peter Bergner
On Mon, 2013-07-15 at 22:35 +0200, Jakub Jelinek wrote: > On Mon, Jul 15, 2013 at 02:46:56PM -0500, Peter Bergner wrote: > > > I'd say something like (but, untested and can't test it right now (and no > > > access to power8 anyway)): > > > > Do we also need to update DWARF_REG_TO_UNWIND_COLUMN sim

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-15 Thread Jakub Jelinek
On Mon, Jul 15, 2013 at 02:46:56PM -0500, Peter Bergner wrote: > > I'd say something like (but, untested and can't test it right now (and no > > access to power8 anyway)): > > Do we also need to update DWARF_REG_TO_UNWIND_COLUMN similarly, which > also uses FIRST_PSEUDO_REGISTER when the dwarf reg

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-15 Thread Peter Bergner
On Mon, 2013-07-15 at 21:13 +0200, Jakub Jelinek wrote: > > Looking at the patch, you've changed FIRST_PSEUDO_REGISTER (internal gcc > > thing, so fine), but that also changed DWARF_FRAME_REGISTER which was > > computed based on FIRST_PSEUDO_REGISTER. Isn't that an ABI break in the > > unwinder (t

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-15 Thread Jakub Jelinek
On Mon, Jul 15, 2013 at 08:44:12PM +0200, Jakub Jelinek wrote: > On Mon, Jul 15, 2013 at 12:25:58PM -0500, Peter Bergner wrote: > > On Mon, 2013-07-15 at 11:55 -0400, David Edelsohn wrote: > > > Thanks for the explanation. Leave it in. > > > > > > Jakub was asking about the status of the HTM patc

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-15 Thread Jakub Jelinek
On Mon, Jul 15, 2013 at 12:25:58PM -0500, Peter Bergner wrote: > On Mon, 2013-07-15 at 11:55 -0400, David Edelsohn wrote: > > Thanks for the explanation. Leave it in. > > > > Jakub was asking about the status of the HTM patch and support, so > > please check it in. > > Ok, committed to mainline

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-15 Thread Peter Bergner
On Mon, 2013-07-15 at 11:55 -0400, David Edelsohn wrote: > Thanks for the explanation. Leave it in. > > Jakub was asking about the status of the HTM patch and support, so > please check it in. Ok, committed to mainline (after another bootstrap) as revision 200960. Thanks! Peter

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-15 Thread David Edelsohn
On Mon, Jul 15, 2013 at 11:23 AM, Peter Bergner wrote: > On Thu, 2013-07-04 at 12:02 -0400, David Edelsohn wrote: >> The expanders in htm.md should not include constraint letters. > > That's the way I had the code originally, since they're not > needed for expand, but I added them later to improve

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-15 Thread Peter Bergner
On Thu, 2013-07-04 at 12:02 -0400, David Edelsohn wrote: > The expanders in htm.md should not include constraint letters. That's the way I had the code originally, since they're not needed for expand, but I added them later to improve the error message when someone uses a builtin that takes an int

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-04 Thread David Edelsohn
On Mon, Jul 1, 2013 at 11:12 PM, Peter Bergner wrote: > On May 10th, the Power Architecture Advisory Council announced the public > availability of Power ISA 2.07. > > https://www.power.org/documentation/power-isa-version-2-07/ > > This patch adds support for Hardware Transactional Memory (HTM)

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-02 Thread Richard Henderson
On 07/01/2013 08:12 PM, Peter Bergner wrote: > libitm/ > * acinclude.m4 (LIBITM_CHECK_AS_HTM): New. > * configure.ac: Use it. > (AC_CHECK_HEADERS): Check for sys/auxv.h. > (AC_CHECK_FUNCS): Check for getauxval. > * config.h.in, configure: Rebuild. > * confi