Re: [PATCH, og8] Add OpenACC 2.6 `acc_get_property' support

2019-01-08 Thread Thomas Schwinge
Hi Maciej! On Mon, 3 Dec 2018 16:51:14 +, "Maciej W. Rozycki" wrote: > Add generic support for the OpenACC 2.6 `acc_get_property' and > `acc_get_property_string' routines, as well as full handlers for the > host and the NVPTX offload targets and a minimal handler for the HSA > offload tar

Re: [PATCH, og8] Add OpenACC 2.6 `acc_get_property' support

2018-12-20 Thread Maciej W. Rozycki
On Mon, 10 Dec 2018, Chung-Lin Tang wrote: > I think the patch is okay, although still needs approval from Thomas and Tom > to commit. I have committed this change now, thank you for your review. Maciej

Re: [PATCH, og8] Add OpenACC 2.6 `acc_get_property' support

2018-12-10 Thread Chung-Lin Tang
On 2018/12/6 2:16 AM, Maciej W. Rozycki wrote: AFAIK, things like strlen are already available in iso_c_binding, in forms like "C_strlen". Can you check again if that 'openacc_c_string' module is really necessary? Any pointers please? I can't see `c_strlen' or any equivalent interface defin

Re: [PATCH, og8] Add OpenACC 2.6 `acc_get_property' support

2018-12-05 Thread Maciej W. Rozycki
Hi Chung-Lin, > > +module openacc_c_string > > + implicit none > > + > > + interface > > +function strlen (s) bind (C, name = "strlen") > > + use iso_c_binding, only: c_ptr, c_size_t > > + type (c_ptr), intent(in), value :: s > > + integer (c_size_t) :: strlen > > +end fun

Re: [PATCH, og8] Add OpenACC 2.6 `acc_get_property' support

2018-12-05 Thread Chung-Lin Tang
Hi Maciej, please see below: On 2018/12/4 12:51 AM, Maciej W. Rozycki wrote: +module openacc_c_string + implicit none + + interface +function strlen (s) bind (C, name = "strlen") + use iso_c_binding, only: c_ptr, c_size_t + type (c_ptr), intent(in), value :: s + integer (c_s

[PATCH, og8] Add OpenACC 2.6 `acc_get_property' support

2018-12-03 Thread Maciej W. Rozycki
Add generic support for the OpenACC 2.6 `acc_get_property' and `acc_get_property_string' routines, as well as full handlers for the host and the NVPTX offload targets and a minimal handler for the HSA offload target. Include test cases for both C/C++ and Fortran support, both producing: OpenAC