Re: [PATCH, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Uros Bizjak
On Sat, Aug 25, 2012 at 11:55 AM, Georg-Johann Lay wrote: >>> For the hook in question, it would be the same effort as far as >>> the hook is concerned: Ir really makes no difference if you >>> >>> - Pass X to the hook and return true or false >>> >>> - Pass X to the hook and return X or NULL_RT

Re: [PATCH, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-25 Thread Georg-Johann Lay
Uros Bizjak schrieb: On Thu, Aug 23, 2012 at 10:46 PM, Georg-Johann Lay wrote: For the hook in question, it would be the same effort as far as the hook is concerned: Ir really makes no difference if you - Pass X to the hook and return true or false - Pass X to the hook and return X or NULL_

Re: [PATCH, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-23 Thread Uros Bizjak
On Thu, Aug 23, 2012 at 8:59 PM, Joseph S. Myers wrote: >> 2012-08-23 Uros Bizjak >> >> * target.def (reject_combined_insn): New target hook. >> * doc/tm.texi.in (TARGET_REJECT_COMBINED_INSN): New hook. >> * doc/tm.texi: Regenerated. > > The preferred location for hook docume

Re: [PATCH, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-23 Thread Uros Bizjak
On Thu, Aug 23, 2012 at 10:46 PM, Georg-Johann Lay wrote: > For the hook in question, it would be the same effort as far as > the hook is concerned: Ir really makes no difference if you > > - Pass X to the hook and return true or false > > - Pass X to the hook and return X or NULL_RTX. > > Howev

Re: [PATCH, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-23 Thread Oleg Endo
On Thu, 2012-08-23 at 22:46 +0200, Georg-Johann Lay wrote: > > > However, I always get surprised when combine would actually take the > > split and continue trying combinations with the insns that came out from > > the split, and when it won't. Sometimes it works, sometimes it doesn't. > > Very

Re: [PATCH, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-23 Thread Georg-Johann Lay
Oleg Endo schrieb: Hello, On Thu, 2012-08-23 at 19:52 +0200, Georg-Johann Lay wrote: Uros Bizjak wrote: Hello! This patch introduces TARGET_REJECT_COMBINED_INSN target hook, so targets are able to reject combinations of two or more insns. The hook is called from recog_for_combine, so it is th

Re: [PATCH, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-23 Thread Joseph S. Myers
On Thu, 23 Aug 2012, Uros Bizjak wrote: > 2012-08-23 Uros Bizjak > > * target.def (reject_combined_insn): New target hook. > * doc/tm.texi.in (TARGET_REJECT_COMBINED_INSN): New hook. > * doc/tm.texi: Regenerated. The preferred location for hook documentation is in the doc st

Re: [PATCH, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-23 Thread Oleg Endo
Hello, On Thu, 2012-08-23 at 19:52 +0200, Georg-Johann Lay wrote: > Uros Bizjak wrote: > > Hello! > > > > This patch introduces TARGET_REJECT_COMBINED_INSN target hook, so > > targets are able to reject combinations of two or more insns. The hook > > is called from recog_for_combine, so it is the

Re: [PATCH, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-23 Thread Uros Bizjak
On Thu, Aug 23, 2012 at 7:52 PM, Georg-Johann Lay wrote: >> This patch introduces TARGET_REJECT_COMBINED_INSN target hook, so >> targets are able to reject combinations of two or more insns. The hook >> is called from recog_for_combine, so it is the target that has the >> final say on the combine

Re: [PATCH, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-23 Thread Uros Bizjak
On Thu, Aug 23, 2012 at 7:59 PM, Andrew Pinski wrote: >>> This patch introduces TARGET_REJECT_COMBINED_INSN target hook, so >>> targets are able to reject combinations of two or more insns. The hook >>> is called from recog_for_combine, so it is the target that has the >>> final say on the combin

Re: [PATCH, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-23 Thread Andrew Pinski
On Thu, Aug 23, 2012 at 10:52 AM, Georg-Johann Lay wrote: > Uros Bizjak wrote: >> Hello! >> >> This patch introduces TARGET_REJECT_COMBINED_INSN target hook, so >> targets are able to reject combinations of two or more insns. The hook >> is called from recog_for_combine, so it is the target that h

Re: [PATCH, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-23 Thread Georg-Johann Lay
Uros Bizjak wrote: > Hello! > > This patch introduces TARGET_REJECT_COMBINED_INSN target hook, so > targets are able to reject combinations of two or more insns. The hook > is called from recog_for_combine, so it is the target that has the > final say on the combined insn. Hi, great place for a

[PATCH, middle-end]: Introduce TARGET_REJECT_COMBINED_INSN target hook

2012-08-23 Thread Uros Bizjak
Hello! This patch introduces TARGET_REJECT_COMBINED_INSN target hook, so targets are able to reject combinations of two or more insns. The hook is called from recog_for_combine, so it is the target that has the final say on the combined insn. This target hook will be used in a follow-up x86 patch