Re: [PATCH, libstdc++] Add the logistic distribution as an extension

2014-07-11 Thread Ed Smith-Rowland
On 07/11/2014 11:42 AM, Paolo Carlini wrote: Hi, On 07/11/2014 05:38 PM, Ed Smith-Rowland wrote: OK? Ok, thanks, but please adjust the dates you have on the testcases to the date of the actual commit (I suppose today or tomorrow) Thanks again! Paolo. As committed. Thanks all for looking a

Re: [PATCH, libstdc++] Add the logistic distribution as an extension

2014-07-11 Thread Paolo Carlini
Hi, On 07/11/2014 05:38 PM, Ed Smith-Rowland wrote: OK? Ok, thanks, but please adjust the dates you have on the testcases to the date of the actual commit (I suppose today or tomorrow) Thanks again! Paolo.

Re: [PATCH, libstdc++] Add the logistic distribution as an extension

2014-07-11 Thread Ed Smith-Rowland
On 07/10/2014 06:16 AM, Paolo Carlini wrote: .. I have another comment: are we sure the usual strategy: template result_type operator()(_UniformRandomNumberGenerator& __urng) { return this->operator()(__urng, this->_M_param); } doesn't make sense here too? Paolo. >> Look OK

Re: [PATCH, libstdc++] Add the logistic distribution as an extension

2014-07-10 Thread Paolo Carlini
.. I have another comment: are we sure the usual strategy: template result_type operator()(_UniformRandomNumberGenerator& __urng) { return this->operator()(__urng, this->_M_param); } doesn't make sense here too? Paolo.

Re: [PATCH, libstdc++] Add the logistic distribution as an extension

2014-07-10 Thread Paolo Carlini
Hi, On 07/10/2014 10:07 AM, Ed Smith-Rowland wrote: The title says it all. I've been bootstrapping and testing with this on x86_64-linux for a month. OK? Look OK to me too, but I would move both operator() out of line, and definitely operator()(_UniformRandomNumberGenerator&, const param_ty

Re: [PATCH, libstdc++] Add the logistic distribution as an extension

2014-07-10 Thread Ulrich Drepper
On Thu, Jul 10, 2014 at 4:07 AM, Ed Smith-Rowland <3dw...@verizon.net> wrote: > The title says it all. > > I've been bootstrapping and testing with this on x86_64-linux for a month. > > OK? Looks good to me.

[PATCH, libstdc++] Add the logistic distribution as an extension

2014-07-10 Thread Ed Smith-Rowland
The title says it all. I've been bootstrapping and testing with this on x86_64-linux for a month. OK? Ed 2014-07-10 Edward Smith-Rowland <3dw...@verizon.net> Add the logistic_distribution as an extension. * include/ext/random: Add the logistic_distribution. * includ