Re: [PATCH, libiberty] Fix PR63758 by using the _NSGetEnviron() API on Darwin.

2015-10-19 Thread Mike Stump
On Oct 18, 2015, at 3:42 AM, Iain Sandoe wrote: This seems likely to break cross-compilers to Darwin that do not have the system libraries available. I guess I don't care about that if you don't. >>> >>> I do care about it, but I'm not visualising the case... >>> >>> AFAICS, when

Re: [PATCH, libiberty] Fix PR63758 by using the _NSGetEnviron() API on Darwin.

2015-10-18 Thread Iain Sandoe
On 8 Sep 2015, at 15:27, Ian Lance Taylor wrote: > On Tue, Sep 8, 2015 at 7:20 AM, Iain Sandoe wrote: >> >>> This seems likely to break cross-compilers to Darwin that do not have >>> the system libraries available. I guess I don't care about that if >>> you don't. >> >> I do care about it, bu

Re: [PATCH, libiberty] Fix PR63758 by using the _NSGetEnviron() API on Darwin.

2015-09-08 Thread Ian Lance Taylor
On Tue, Sep 8, 2015 at 7:20 AM, Iain Sandoe wrote: > >> This seems likely to break cross-compilers to Darwin that do not have >> the system libraries available. I guess I don't care about that if >> you don't. > > I do care about it, but I'm not visualising the case... > > AFAICS, when built as a

Re: [PATCH, libiberty] Fix PR63758 by using the _NSGetEnviron() API on Darwin.

2015-09-08 Thread Iain Sandoe
On 8 Sep 2015, at 15:00, Ian Lance Taylor wrote: > On Mon, Sep 7, 2015 at 8:23 AM, Iain Sandoe wrote: >> >> include/ >> >>Roland McGrath >> >>PR other/63758 >>* environ.h: New file. >> >> libiberty/ >> >>Roland McGrath >>Iain Sandoe >> >>

Re: [PATCH, libiberty] Fix PR63758 by using the _NSGetEnviron() API on Darwin.

2015-09-08 Thread Ian Lance Taylor
On Mon, Sep 7, 2015 at 8:23 AM, Iain Sandoe wrote: > > include/ > > Roland McGrath > > PR other/63758 > * environ.h: New file. > > libiberty/ > > Roland McGrath > Iain Sandoe > > PR other/63758 > * pex-unix.c: Obtain the environment int

Re: [PATCH, libiberty] Fix PR63758 by using the _NSGetEnviron() API on Darwin.

2015-09-07 Thread Mike Stump
On Sep 7, 2015, at 8:23 AM, Iain Sandoe wrote: > On Darwin platforms, when referenced from the main executable, it's permitted > to access *_environ directly. > OK for trunk and active branches? Darwin bits Ok.

[PATCH, libiberty] Fix PR63758 by using the _NSGetEnviron() API on Darwin.

2015-09-07 Thread Iain Sandoe
Hi, This is mostly Roland's patch with one extra case added by me plus I moved the new header to include/ as suggested in c#7 of the PR since there are other users for it in the compiler. == On Darwin platforms, when referenced from the main executable, it's permitted to access *_environ dire