Re: [PATCH, libbacktrace]: Fix compilation on CentOS 5.8

2012-09-18 Thread Ian Lance Taylor
On Tue, Sep 18, 2012 at 9:08 AM, Joseph S. Myers wrote: > > I think AC_USE_SYSTEM_EXTENSIONS is preferred to defining _GNU_SOURCE in > individual source files. Thanks for the pointer. I have committed this patch after bootstrap and libbacktrace test on x86_64-unknown-linux-gnu. Ian 2012-09-18

Re: [PATCH, libbacktrace]: Fix compilation on CentOS 5.8

2012-09-18 Thread Joseph S. Myers
On Tue, 18 Sep 2012, Uros Bizjak wrote: > Index: dwarf.c > === > --- dwarf.c (revision 191413) > +++ dwarf.c (working copy) > @@ -30,6 +30,8 @@ > IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > POSSIBILI

Re: [PATCH, libbacktrace]: Fix compilation on CentOS 5.8

2012-09-18 Thread Ian Lance Taylor
On Tue, Sep 18, 2012 at 7:08 AM, Ian Lance Taylor wrote: > > I'll fix the strnlen issue some other way. I committed a pair of patches, to libiberty and libbacktrace, that should fix the problem. Let me know if it is still present. Sorry for the difficulty. Ian

Re: [PATCH, libbacktrace]: Fix compilation on CentOS 5.8

2012-09-18 Thread Andreas Schwab
Ian Lance Taylor writes: > mmapio.c uses _GNU_SOURCE so that getpagesize is available on GNU/Linux > systems. That should be available by default (which includes BSD things) unless the namespace has been restricted in some other way. There's of course also the POSIX way of using sysconf(_SC_PA

Re: [PATCH, libbacktrace]: Fix compilation on CentOS 5.8

2012-09-18 Thread Ian Lance Taylor
On Tue, Sep 18, 2012 at 2:25 AM, Uros Bizjak wrote: > On Tue, Sep 18, 2012 at 11:16 AM, Richard Guenther > wrote: > >>> CentOS 5.8 uses glibc version 2.5 that needs _GNU_SOURCE defined to use >>> strnlen. >> >> Hm, shouldn't libiberty contain a xstrnlen? I bet strnlen isn't available >> everywh

Re: [PATCH, libbacktrace]: Fix compilation on CentOS 5.8

2012-09-18 Thread Richard Guenther
On Tue, Sep 18, 2012 at 11:25 AM, Uros Bizjak wrote: > On Tue, Sep 18, 2012 at 11:16 AM, Richard Guenther > wrote: > >>> CentOS 5.8 uses glibc version 2.5 that needs _GNU_SOURCE defined to use >>> strnlen. >> >> Hm, shouldn't libiberty contain a xstrnlen? I bet strnlen isn't available >> everyw

Re: [PATCH, libbacktrace]: Fix compilation on CentOS 5.8

2012-09-18 Thread Dominique Dhumieres
> ... I bet strnlen isn't available everywhere. You won!-(it is not available on darwin10) I had to change the strnlen to strlen in order to bootstrap. Dominique

Re: [PATCH, libbacktrace]: Fix compilation on CentOS 5.8

2012-09-18 Thread Uros Bizjak
On Tue, Sep 18, 2012 at 11:16 AM, Richard Guenther wrote: >> CentOS 5.8 uses glibc version 2.5 that needs _GNU_SOURCE defined to use >> strnlen. > > Hm, shouldn't libiberty contain a xstrnlen? I bet strnlen isn't available > everywhere. I didn't find it in the sources. OTOH, mmapio.c already

Re: [PATCH, libbacktrace]: Fix compilation on CentOS 5.8

2012-09-18 Thread Richard Guenther
On Tue, Sep 18, 2012 at 11:09 AM, Uros Bizjak wrote: > Hello! > > CentOS 5.8 uses glibc version 2.5 that needs _GNU_SOURCE defined to use > strnlen. Hm, shouldn't libiberty contain a xstrnlen? I bet strnlen isn't available everywhere. Richard. > 2012-09-18 Uros Bizjak > > * dwarf.c

[PATCH, libbacktrace]: Fix compilation on CentOS 5.8

2012-09-18 Thread Uros Bizjak
Hello! CentOS 5.8 uses glibc version 2.5 that needs _GNU_SOURCE defined to use strnlen. 2012-09-18 Uros Bizjak * dwarf.c: Define _GNU_SOURCE. Tested on CentOS x86_64-pc-linux-gnu. OK for mainline? Uros. Index: dwarf.c