Re: [PATCH, gfortran] Cleanup the submodule tests

2017-06-04 Thread Segher Boessenkool
On Sun, Jun 04, 2017 at 02:52:36PM +0200, Dominique d'Humières wrote: > >> - regexp "(\[0-9\]+)\[ \t\]+(?:(?:#)?\[ \t\]*include\[ > >> \t\]+)\[\"\](\[^\"\]*)\[\"\]" $i dummy lineno include_file > >> + regexp -nocase > >> "(\[0-9\]+)\\s+(?:(?:#)?\\s*include\\s+)\[\"\'\](\[^\"\'

Fwd: [PATCH, gfortran] Cleanup the submodule tests

2017-06-04 Thread Dominique d'Humières
> Début du message réexpédié : > > De: Dominique d'Humières > Objet: Rép : [PATCH, gfortran] Cleanup the submodule tests > Date: 4 juin 2017 à 14:52:36 UTC+2 > À: Janus Weil > Cc: Paul Richard Thomas , > seg...@kernel.crashing.org, gfortran , gcc-patches > &

Re: [PATCH, gfortran] Cleanup the submodule tests

2017-04-17 Thread Segher Boessenkool
On Sun, Apr 16, 2017 at 10:13:07PM +0200, Janus Weil wrote: > > if {![string match "" $tmp]} { > > foreach i $tmp { > > - regexp "(\[0-9\]+)\[ \t\]+(?:(?:#)?\[ \t\]*include\[ > > \t\]+)\[\"\](\[^\"\]*)\[\"\]" $i dummy lineno include_file > > + regexp -nocase > > "

Re: [PATCH, gfortran] Cleanup the submodule tests

2017-04-16 Thread Janus Weil
Hi Dominique, > I am currently testing the following patch that handle both modules and > submodules. It is a little bit clumsy and may not handle all the possible > syntax variants. Any comment welcomed!-) Testing in progress. so, how did the testing go? > proc list-module-names-1 { file }

Re: [PATCH, gfortran] Cleanup the submodule tests

2017-04-15 Thread Dominique d'Humières
I am currently testing the following patch that handle both modules and submodules. It is a little bit clumsy and may not handle all the possible syntax variants. Any comment welcomed!-) Testing in progress. Dominique --- ../_clean/gcc/testsuite/lib/fortran-modules.exp 2017-01-01 17:38:58.

Re: [PATCH, gfortran] Cleanup the submodule tests

2017-04-15 Thread Janus Weil
2017-04-15 17:54 GMT+02:00 Dominique d'Humières : >>> This is indeed doable, but before I’ld like to improve the module cleanup >>> with the following patch >> >> Yes, looks very useful to me (makes the regexps much more compact & >> readable). In addition, couldn't one use \s for whitespace inste

Re: [PATCH, gfortran] Cleanup the submodule tests

2017-04-15 Thread Dominique d'Humières
> Le 15 avr. 2017 à 17:13, Janus Weil a écrit : > > 2017-04-15 15:57 GMT+02:00 Dominique d'Humières : >> >>> Le 15 avr. 2017 à 13:00, Janus Weil a écrit : >>> >>> Hi Dominique, >>> >>> if I'm not mistaken, the cleanup of module file in the testsuite is >>> done automatically by now, right? C

Re: [PATCH, gfortran] Cleanup the submodule tests

2017-04-15 Thread Janus Weil
2017-04-15 15:57 GMT+02:00 Dominique d'Humières : > >> Le 15 avr. 2017 à 13:00, Janus Weil a écrit : >> >> Hi Dominique, >> >> if I'm not mistaken, the cleanup of module file in the testsuite is >> done automatically by now, right? Couldn't one do the same also for >> submodules? >> >> Cheers, >>

Re: [PATCH, gfortran] Cleanup the submodule tests

2017-04-15 Thread Dominique d'Humières
> Le 15 avr. 2017 à 13:00, Janus Weil a écrit : > > Hi Dominique, > > if I'm not mistaken, the cleanup of module file in the testsuite is > done automatically by now, right? Couldn't one do the same also for > submodules? > > Cheers, > Janus > This is indeed doable, but before I’ld like to i

Re: [PATCH, gfortran] Cleanup the submodule tests

2017-04-15 Thread Janus Weil
Hi Dominique, if I'm not mistaken, the cleanup of module file in the testsuite is done automatically by now, right? Couldn't one do the same also for submodules? Cheers, Janus 2017-04-15 10:34 GMT+02:00 Dominique d'Humières : > Hi! > > Unless someone objects, I am planning to commit the follow

[PATCH, gfortran] Cleanup the submodule tests

2017-04-15 Thread Dominique d'Humières
Hi! Unless someone objects, I am planning to commit the following cleanup --- ../_clean/gcc/testsuite/gfortran.dg/submodule_17.f082016-08-24 21:57:16.0 +0200 +++ gcc/testsuite/gfortran.dg/submodule_17.f08 2017-04-15 10:19:32.0 +0200 @@ -25,3 +25,4 @@ end submodule us