Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

Hi Andre, >> >> For the >> >> second one (in gfc_conv_expr), I don't directly see how it's related >> >> to deferred char-len. Why is this change needed? >> > >> > That change is needed, because in some rare case where an associated >> > variable in a "select type ()" is used, then the type and f9

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

Hi Janus, thanks for the quick response. Please see my answers inline. On Sat, 3 Jan 2015 13:12:28 +0100 Janus Weil wrote: > > I started with the initializer for the _len component and ran into "Pointer > > assignment target is neither TARGET nor POINTER at %L" errors > > (expr.c:3714). I trac

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

Hi Andre, >> 1) There are still two TODO markers in the patch. It might be a good >> idea to take care of them before committing the patch. In particular >> for the first one (adding the initializer in gfc_build_class_symbol) >> it would be good to understand where those problems come from. > > I

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

Hi Janus, thank you for your review. > I had a look over the patch, and it looks mostly fine to me. A few remarks: > > 1) There are still two TODO markers in the patch. It might be a good > idea to take care of them before committing the patch. In particular > for the first one (adding the init

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

Hi Andre, > Now, the patch was not intended to solve 61337. Although I have looked into > the > pseudo code generated for 61337, I couldn't figure easily what is going on > there. In my impression, this is something from incorrectly computed bounds to > an integer(8),pointer integer(4),pointer mi

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

Hi all, sorry for duplicates, but the initial answer was rejected by the qmail-daemon of the fortran-list due to my mobile sending html. Now, the patch was not intended to solve 61337. Although I have looked into the pseudo code generated for 61337, I couldn't figure easily what is going on there

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

The new patch fixes the ICEs, but still emit the wrong codes reported in pr61337. Thanks and Happy New Year to all, Dominique > Le 30 déc. 2014 à 14:39, Andre Vehreschild a écrit : > > Hi Dominique, > > thanks for pointing that out. That was caused by a flaw in the current patch. > In the at

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

Hi Dominique, thanks for pointing that out. That was caused by a flaw in the current patch. In the attached version this is fixed now. Bootstraps and regtests ok on x86_64-linux-gnu. Regards, Andre On Mon, 29 Dec 2014 16:32:27 +0100 Dominique d'Humières wrote: > For the record, compil

Re: [PATCH, fortran, final] PR fortran/60255 Deferred character length

For the record, compiling the tests in pr61337 with the patch applied on top of r219099 gives ICEs: use array_list 1 internal compiler error: in gfc_advance_chain, at fortran/trans.c:58 Since this replaces some wrong-code generation by some ICEs, I don’t think this should delay the fix of p

[PATCH, fortran, final] PR fortran/60255 Deferred character length

Hi all, attached is the patch and changelog for fixing pr60255. All comments I received have been integrated into the current patch, therefore I submit this patch as final and hope to see it in trunk soon. The patch fixes the assignment of deferred length char arrays to unlimited polymorphic ent