Re: [PATCH, aarch64] Fix pr69305 -- addti miscompilation

2016-01-28 Thread Richard Henderson
Here's the patch as committed. It includes a few name changes from the addv patch I posted, which correspond nicely with a name clarification that James requested during feedback. r~ PR target/69305 * config/aarch64/aarch64-modes.def (CC_Cmode): New * config/aarch64/aarch

Re: [PATCH, aarch64] Fix pr69305 -- addti miscompilation

2016-01-27 Thread Richard Henderson
On 01/27/2016 09:31 AM, James Greenhalgh wrote: >> +(define_insn "*add3_compare1_cconly" > > I don't understand the naming scheme, it got me a wee bit confused with > add3_compare0 and friends, where the 0 indicates a comparison with > zero... Ah, well, I didn't get that 0 indicated comparison wi

Re: [PATCH, aarch64] Fix pr69305 -- addti miscompilation

2016-01-27 Thread James Greenhalgh
On Sun, Jan 24, 2016 at 03:19:35AM -0800, Richard Henderson wrote: > As Jakub notes in the PR, the representation for add_compare and > sub_compare were wrong. And several of the add_carryin patterns > were duplicates. > > This adds a CC_Cmode for which only the Carry bit is valid. > > The patch

[PATCH, aarch64] Fix pr69305 -- addti miscompilation

2016-01-24 Thread Richard Henderson
As Jakub notes in the PR, the representation for add_compare and sub_compare were wrong. And several of the add_carryin patterns were duplicates. This adds a CC_Cmode for which only the Carry bit is valid. The patch appears to generate moderately decent code. For gcc7 we should look into why