Re: [PATCH, aarch64] Fix 61545

2014-06-18 Thread Kyle McMartin
On Wed, Jun 18, 2014 at 04:04:53PM -0700, Richard Henderson wrote: > On 06/18/2014 03:57 PM, Kyle McMartin wrote: > > pretty sure we need a similar fix for tlsgd_small, since __tls_get_addr > > could clobber CC as well. > > As I replied in IRC, no, because tlsgd_small is modeled with an actual > C

Re: [PATCH, aarch64] Fix 61545

2014-06-18 Thread Richard Henderson
On 06/18/2014 03:57 PM, Kyle McMartin wrote: > pretty sure we need a similar fix for tlsgd_small, since __tls_get_addr > could clobber CC as well. As I replied in IRC, no, because tlsgd_small is modeled with an actual CALL_INSN, and thus call-clobbered registers work as normal. r~

Re: [PATCH, aarch64] Fix 61545

2014-06-18 Thread Kyle McMartin
On Tue, Jun 17, 2014 at 10:19:06PM -0700, Richard Henderson wrote: > Trivial fix for missing clobber of the flags over the tlsdesc call. > > Ok for all branches? > > > r~ > > * config/aarch64/aarch64.md (tlsdesc_small_): Clobber CC_REGNUM. > pretty sure we need a similar fix for tlsgd_s

Re: [PATCH, aarch64] Fix 61545

2014-06-18 Thread Richard Earnshaw
On 18/06/14 06:19, Richard Henderson wrote: > Trivial fix for missing clobber of the flags over the tlsdesc call. > > Ok for all branches? > > OK. R. > r~ > > * config/aarch64/aarch64.md (tlsdesc_small_): Clobber CC_REGNUM. > > > z > > > diff --git a/gcc/config/aarch64/aarch64.md b

[PATCH, aarch64] Fix 61545

2014-06-17 Thread Richard Henderson
Trivial fix for missing clobber of the flags over the tlsdesc call. Ok for all branches? r~ * config/aarch64/aarch64.md (tlsdesc_small_): Clobber CC_REGNUM. diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md index a4d8887..1ee2cae 100644 --- a/gcc/config/aarch64