Re: [PATCH, SMS] Free sccs field

2011-04-15 Thread Revital Eres
Hello, On 15 April 2011 18:53, Nathan Froyd wrote: > On Fri, Apr 15, 2011 at 06:27:05PM +0300, Revital Eres wrote: >> +  if (all_sccs->sccs) >> +    free (all_sccs->sccs); > > No need to check for non-NULL prior to free'ing. OK, I'll commit the patch without the check then. (after re-testing) T

Re: [PATCH, SMS] Free sccs field

2011-04-15 Thread Nathan Froyd
On Fri, Apr 15, 2011 at 06:27:05PM +0300, Revital Eres wrote: > + if (all_sccs->sccs) > +free (all_sccs->sccs); No need to check for non-NULL prior to free'ing. -Nathan

Re: [PATCH, SMS] Free sccs field

2011-04-15 Thread Richard Guenther
On Fri, Apr 15, 2011 at 5:27 PM, Revital Eres wrote: > Hello, > > The attached patch adds missing free operation for storage > allocated while calculating SCCs. > > Bootstrap and regtested on ppc64-redhat-linux. > > OK for mainline? Ok. Thanks, Richard. > Thanks, > Revital > > Changelog: > >  

[PATCH, SMS] Free sccs field

2011-04-15 Thread Revital Eres
Hello, The attached patch adds missing free operation for storage allocated while calculating SCCs. Bootstrap and regtested on ppc64-redhat-linux. OK for mainline? Thanks, Revital Changelog: * ddg.c (free_ddg_all_sccs): Free sccs field in struct ddg_all_sccs. Index: ddg.c ===