Re: [PATCH, RFC, gfortran] Multi-threaded random number generator

2015-12-25 Thread Janne Blomqvist
On Thu, Dec 24, 2015 at 7:54 PM, Steve Kargl wrote: > On Thu, Dec 24, 2015 at 04:53:30PM +0200, Janne Blomqvist wrote: >> On Thu, Dec 24, 2015 at 1:18 AM, Steve Kargl >> wrote: >> > Two questions. >> > >> > 1) Does the patch deal with PR 52879? >> >> To be honest, I haven't tested. FWIW, the pap

Re: [PATCH, RFC, gfortran] Multi-threaded random number generator

2015-12-25 Thread Janne Blomqvist
On Fri, Dec 25, 2015 at 2:39 AM, Damian Rouson wrote: > Does this patch change the behavior of multi-image programs the run with one > thread per image, where each image an MPI rank? I assume the answer is no. AFAICT, no. Or well, as I mentioned previously, the sequence of random numbers is dif

Re: [PATCH, RFC, gfortran] Multi-threaded random number generator

2015-12-24 Thread Steve Kargl
On Thu, Dec 24, 2015 at 04:53:30PM +0200, Janne Blomqvist wrote: > On Thu, Dec 24, 2015 at 1:18 AM, Steve Kargl > wrote: > > On Thu, Dec 24, 2015 at 12:29:02AM +0200, Janne Blomqvist wrote: > >> > >> the GFortran random number generator (RANDOM_NUMBER and RANDOM_SEED > >> intrinsics) has a number

Re: [PATCH, RFC, gfortran] Multi-threaded random number generator

2015-12-24 Thread Janne Blomqvist
On Thu, Dec 24, 2015 at 1:18 AM, Steve Kargl wrote: > On Thu, Dec 24, 2015 at 12:29:02AM +0200, Janne Blomqvist wrote: >> >> the GFortran random number generator (RANDOM_NUMBER and RANDOM_SEED >> intrinsics) has a number of issues that the attached preliminary patch >> tries to address. >> > > Fir

Re: [PATCH, RFC, gfortran] Multi-threaded random number generator

2015-12-23 Thread Steve Kargl
On Thu, Dec 24, 2015 at 12:29:02AM +0200, Janne Blomqvist wrote: > > the GFortran random number generator (RANDOM_NUMBER and RANDOM_SEED > intrinsics) has a number of issues that the attached preliminary patch > tries to address. > First, I think your effort to retool random numbers is a nice en

[PATCH, RFC, gfortran] Multi-threaded random number generator

2015-12-23 Thread Janne Blomqvist
Hi, the GFortran random number generator (RANDOM_NUMBER and RANDOM_SEED intrinsics) has a number of issues that the attached preliminary patch tries to address. - 64-bit integers are available on all targets GFortran supports, and the vast majority of users nowadays use targets with native 64-b