Re: [PATCH, Pointer Bounds Checker 27/x] Strlen

2014-08-05 Thread Ilya Enkovich
eOn 31 Jul 14:07, Ilya Enkovich wrote: > 2014-06-11 12:22 GMT+04:00 Jakub Jelinek : > > On Wed, Jun 11, 2014 at 12:14:14PM +0400, Ilya Enkovich wrote: > >> This patch adds instrumented code support for strlen optimization. > >> > >> Bootstrapped and tested on linux-x86_64. > >> > >> Does it look OK

Re: [PATCH, Pointer Bounds Checker 27/x] Strlen

2014-07-31 Thread Ilya Enkovich
2014-06-11 12:22 GMT+04:00 Jakub Jelinek : > On Wed, Jun 11, 2014 at 12:14:14PM +0400, Ilya Enkovich wrote: >> This patch adds instrumented code support for strlen optimization. >> >> Bootstrapped and tested on linux-x86_64. >> >> Does it look OK? > > Ugh, this looks terribly ugly. So you are chan

Re: [PATCH, Pointer Bounds Checker 27/x] Strlen

2014-06-11 Thread Ilya Enkovich
2014-06-11 12:55 GMT+04:00 Jakub Jelinek : > On Wed, Jun 11, 2014 at 12:44:29PM +0400, Ilya Enkovich wrote: >> 2014-06-11 12:22 GMT+04:00 Jakub Jelinek : >> > On Wed, Jun 11, 2014 at 12:14:14PM +0400, Ilya Enkovich wrote: >> >> This patch adds instrumented code support for strlen optimization. >> >

Re: [PATCH, Pointer Bounds Checker 27/x] Strlen

2014-06-11 Thread Ilya Enkovich
2014-06-11 13:00 GMT+04:00 Marek Polacek : > On Wed, Jun 11, 2014 at 12:14:14PM +0400, Ilya Enkovich wrote: >> This patch adds instrumented code support for strlen optimization. >> >> Bootstrapped and tested on linux-x86_64. >> >> Does it look OK? > > I haven't followed the Pointer Bounds Checker d

Re: [PATCH, Pointer Bounds Checker 27/x] Strlen

2014-06-11 Thread Marek Polacek
On Wed, Jun 11, 2014 at 12:14:14PM +0400, Ilya Enkovich wrote: > This patch adds instrumented code support for strlen optimization. > > Bootstrapped and tested on linux-x86_64. > > Does it look OK? I haven't followed the Pointer Bounds Checker development, only looked at some of the patches, but

Re: [PATCH, Pointer Bounds Checker 27/x] Strlen

2014-06-11 Thread Jakub Jelinek
On Wed, Jun 11, 2014 at 12:44:29PM +0400, Ilya Enkovich wrote: > 2014-06-11 12:22 GMT+04:00 Jakub Jelinek : > > On Wed, Jun 11, 2014 at 12:14:14PM +0400, Ilya Enkovich wrote: > >> This patch adds instrumented code support for strlen optimization. > >> > >> Bootstrapped and tested on linux-x86_64. >

Re: [PATCH, Pointer Bounds Checker 27/x] Strlen

2014-06-11 Thread Ilya Enkovich
2014-06-11 12:22 GMT+04:00 Jakub Jelinek : > On Wed, Jun 11, 2014 at 12:14:14PM +0400, Ilya Enkovich wrote: >> This patch adds instrumented code support for strlen optimization. >> >> Bootstrapped and tested on linux-x86_64. >> >> Does it look OK? > > Ugh, this looks terribly ugly. So you are chan

Re: [PATCH, Pointer Bounds Checker 27/x] Strlen

2014-06-11 Thread Jakub Jelinek
On Wed, Jun 11, 2014 at 12:14:14PM +0400, Ilya Enkovich wrote: > This patch adds instrumented code support for strlen optimization. > > Bootstrapped and tested on linux-x86_64. > > Does it look OK? Ugh, this looks terribly ugly. So you are changing the meaning of arguments of every single built

[PATCH, Pointer Bounds Checker 27/x] Strlen

2014-06-11 Thread Ilya Enkovich
Hi, This patch adds instrumented code support for strlen optimization. Bootstrapped and tested on linux-x86_64. Does it look OK? Thanks, Ilya -- gcc/ 2014-06-09 Ilya Enkovich * tree-ssa-strlen.c: include tree-chkp.h. (get_string_length): Handle calls with bounds. (a