Re: [PATCH, PR69068] Handle 3-arg phi in copy_bb_and_scalar_dependences

2016-05-30 Thread Richard Biener
On Mon, 30 May 2016, Tom de Vries wrote: > On 30/05/16 12:56, Richard Biener wrote: > > On Mon, 30 May 2016, Tom de Vries wrote: > > > > > >On 30/05/16 11:46, Richard Biener wrote: > > > > > > > >This patch fixes the assert conservatively by aborting graphite > > > > > code > > > > > > > > > >gen

Re: [PATCH, PR69068] Handle 3-arg phi in copy_bb_and_scalar_dependences

2016-05-30 Thread Tom de Vries
On 30/05/16 12:56, Richard Biener wrote: On Mon, 30 May 2016, Tom de Vries wrote: >On 30/05/16 11:46, Richard Biener wrote: > > >This patch fixes the assert conservatively by aborting graphite code > > > >generation when encountering a phi with more than two arguments in > > > >copy_bb_and_sc

Re: [PATCH, PR69068] Handle 3-arg phi in copy_bb_and_scalar_dependences

2016-05-30 Thread Richard Biener
On Mon, 30 May 2016, Tom de Vries wrote: > On 30/05/16 11:46, Richard Biener wrote: > > > This patch fixes the assert conservatively by aborting graphite code > > > >generation when encountering a phi with more than two arguments in > > > >copy_bb_and_scalar_dependences. > > > > > > > >Bootstrappe

Re: [PATCH, PR69068] Handle 3-arg phi in copy_bb_and_scalar_dependences

2016-05-30 Thread Tom de Vries
On 30/05/16 11:46, Richard Biener wrote: This patch fixes the assert conservatively by aborting graphite code >generation when encountering a phi with more than two arguments in >copy_bb_and_scalar_dependences. > >Bootstrapped and reg-tested on x86_64. > >OK for trunk, 6 branch? Did you check

Re: [PATCH, PR69068] Handle 3-arg phi in copy_bb_and_scalar_dependences

2016-05-30 Thread Richard Biener
On Mon, 30 May 2016, Tom de Vries wrote: > Hi, > > this patch fixes graphite PR69068, a 6/7 regression. > > > I. > > Consider this test-case: > ... > int qo; > int zh[2]; > > void > td (void) > { > int ly, en; > for (ly = 0; ly < 2; ++ly) > for (en = 0; en < 2; ++en) > zh[en] =

[PATCH, PR69068] Handle 3-arg phi in copy_bb_and_scalar_dependences

2016-05-30 Thread Tom de Vries
Hi, this patch fixes graphite PR69068, a 6/7 regression. I. Consider this test-case: ... int qo; int zh[2]; void td (void) { int ly, en; for (ly = 0; ly < 2; ++ly) for (en = 0; en < 2; ++en) zh[en] = ((qo == 0) || (((qo * 2) != 0))) ? 1 : -1; } ... When compiling with -O1 -fgra