Re: [PATCH, PR68715] Add missing single_pred_p test in scop_detection::merge_sese

2016-03-16 Thread Tom de Vries
On 16/03/16 09:53, Richard Biener wrote: Hmm, it looks like for all what this function does this effectively pessimizes scop merging and it would be easier to split 'exit' in case its destination is unsuitable (not trivially empty). Agreed. The /* For now we just want to bail out when ex

Re: [PATCH, PR68715] Add missing single_pred_p test in scop_detection::merge_sese

2016-03-16 Thread Richard Biener
On Wed, 16 Mar 2016, Tom de Vries wrote: > Hi, > > this patch fixes graphite PR68715, a 6 regression. > > In scop_detection::merge_sese, we check if the exit bb of the merged sese > region is dominated by the entry bb: > ... > if (... > || !dominated_by_p (CDI_DOMINATORS, get_exit_bb (co

[PATCH, PR68715] Add missing single_pred_p test in scop_detection::merge_sese

2016-03-16 Thread Tom de Vries
Hi, this patch fixes graphite PR68715, a 6 regression. In scop_detection::merge_sese, we check if the exit bb of the merged sese region is dominated by the entry bb: ... if (... || !dominated_by_p (CDI_DOMINATORS, get_exit_bb (combined), get_entry_bb (combined