Re: [PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-13 Thread Jeff Law
On 06/11/14 15:45, Ilya Enkovich wrote: On 11 Jun 22:47, Uros Bizjak wrote: This should read: /* { dg-do compile { target { ia32 } } } */ /* { dg-options "-O2 -march=corei7 -mfpmath=387" } */ The x86 part is OK with this change. Uros. Thanks for comment! Here is a fixed version. Ilya --

Re: [PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-12 Thread Jeff Law
On 06/10/14 01:42, Ilya Enkovich wrote: Hi, This patch fixes PR61446. The problem appears when we insert value copies after transformations. We use the widest extension mode met in a chain, but it may be wider than original destination register size. This patch checks it and use smaller mod

Re: [PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-12 Thread Jeff Law
On 06/10/14 01:42, Ilya Enkovich wrote: Hi, This patch fixes PR61446. The problem appears when we insert value copies after transformations. We use the widest extension mode met in a chain, but it may be wider than original destination register size. This patch checks it and use smaller mod

Re: [PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-11 Thread Ilya Enkovich
On 11 Jun 22:47, Uros Bizjak wrote: > > This should read: > > /* { dg-do compile { target { ia32 } } } */ > /* { dg-options "-O2 -march=corei7 -mfpmath=387" } */ > > The x86 part is OK with this change. > > Uros. Thanks for comment! Here is a fixed version. Ilya -- gcc/ 2014-06-11 Ilya Enk

Re: [PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-11 Thread Uros Bizjak
On Wed, Jun 11, 2014 at 6:11 PM, Ilya Enkovich wrote: > On 11 Jun 14:59, Uros Bizjak wrote: >> On Tue, Jun 10, 2014 at 3:45 PM, Dominique Dhumieres >> wrote: >> >> This patch fixes PR61446. ... >> > >> > Confirmed, it also allows to bootstrap Core* targets. >> > Could it be reviewed and committe

Re: [PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-11 Thread Ilya Enkovich
On 11 Jun 14:59, Uros Bizjak wrote: > On Tue, Jun 10, 2014 at 3:45 PM, Dominique Dhumieres > wrote: > >> This patch fixes PR61446. ... > > > > Confirmed, it also allows to bootstrap Core* targets. > > Could it be reviewed and committed ASAP? > > > 2014-06-09 Ilya Enkovich > > > > PR 61446 > >

Re: [PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-11 Thread Dominique Dhumieres
> Yes, these are bootstraps with non-default configurations. Core2 is the default for darwin and bootstrap is also broken for it without the patch. Dominique

Re: [PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-11 Thread Uros Bizjak
On Wed, Jun 11, 2014 at 3:19 PM, Dominique Dhumieres wrote: >> (I am not RTL reviewer, so I can't approve the patch). > > Is https://gcc.gnu.org/ml/gcc-regression/2014-06/ accepatble? Yes, these are bootstraps with non-default configurations. Uros.

Re: [PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-11 Thread Dominique Dhumieres
> (I am not RTL reviewer, so I can't approve the patch). Is https://gcc.gnu.org/ml/gcc-regression/2014-06/ accepatble? Dominique

Re: [PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-11 Thread Uros Bizjak
On Tue, Jun 10, 2014 at 3:45 PM, Dominique Dhumieres wrote: >> This patch fixes PR61446. ... > > Confirmed, it also allows to bootstrap Core* targets. > Could it be reviewed and committed ASAP? > 2014-06-09 Ilya Enkovich > > PR 61446 > * ree.c (find_and_remove_re): Narrow mode for register cop

Re: [PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-10 Thread Dominique Dhumieres
> This patch fixes PR61446. ... Confirmed, it also allows to bootstrap Core* targets. Could it be reviewed and committed ASAP? TIA Dominique

[PATCH, PR61446] Fix mode for register copy in REE pass

2014-06-10 Thread Ilya Enkovich
Hi, This patch fixes PR61446. The problem appears when we insert value copies after transformations. We use the widest extension mode met in a chain, but it may be wider than original destination register size. This patch checks it and use smaller mode if required. Bootstrapped and tested on