Re: [PING PATCH, PR 57748] Set mode of structures with zero sized arrays to be BLK

2013-08-28 Thread Martin Jambor
On Wed, Aug 28, 2013 at 10:17:52AM +0200, Richard Biener wrote: > On Wed, 28 Aug 2013, Richard Biener wrote: > > Eh ... :/ > > > > I'm extremely nervous about this change. I also believe the change > > is unrelated to the issue in the bugreport (even if it happens to > > fix the ICE). > > > > Le

Re: [PING PATCH, PR 57748] Set mode of structures with zero sized arrays to be BLK

2013-08-28 Thread Richard Biener
On Wed, 28 Aug 2013, Richard Biener wrote: > On Tue, 27 Aug 2013, Jakub Jelinek wrote: > > > On Tue, Aug 27, 2013 at 04:03:42PM +0200, Martin Jambor wrote: > > > On Fri, Aug 23, 2013 at 05:29:23PM +0200, Jakub Jelinek wrote: > > > > On Fri, Aug 23, 2013 at 05:11:22PM +0200, Martin Jambor wrote: >

Re: [PING PATCH, PR 57748] Set mode of structures with zero sized arrays to be BLK

2013-08-28 Thread Richard Biener
On Tue, 27 Aug 2013, Jakub Jelinek wrote: > On Tue, Aug 27, 2013 at 04:03:42PM +0200, Martin Jambor wrote: > > On Fri, Aug 23, 2013 at 05:29:23PM +0200, Jakub Jelinek wrote: > > > On Fri, Aug 23, 2013 at 05:11:22PM +0200, Martin Jambor wrote: > > > > Hi Jakub and/or Joseph, > > > > > > > > the re

Re: [PING PATCH, PR 57748] Set mode of structures with zero sized arrays to be BLK

2013-08-27 Thread Jakub Jelinek
On Tue, Aug 27, 2013 at 04:03:42PM +0200, Martin Jambor wrote: > On Fri, Aug 23, 2013 at 05:29:23PM +0200, Jakub Jelinek wrote: > > On Fri, Aug 23, 2013 at 05:11:22PM +0200, Martin Jambor wrote: > > > Hi Jakub and/or Joseph, > > > > > > the reporter of this bug seems to be very anxious to have it

Re: [PING PATCH, PR 57748] Set mode of structures with zero sized arrays to be BLK

2013-08-27 Thread Martin Jambor
Hi, On Fri, Aug 23, 2013 at 05:29:23PM +0200, Jakub Jelinek wrote: > On Fri, Aug 23, 2013 at 05:11:22PM +0200, Martin Jambor wrote: > > Hi Jakub and/or Joseph, > > > > the reporter of this bug seems to be very anxious to have it fixed in > > the repository. While Richi is away, do you think you

Re: [PING PATCH, PR 57748] Set mode of structures with zero sized arrays to be BLK

2013-08-23 Thread Jakub Jelinek
On Fri, Aug 23, 2013 at 05:11:22PM +0200, Martin Jambor wrote: > Hi Jakub and/or Joseph, > > the reporter of this bug seems to be very anxious to have it fixed in > the repository. While Richi is away, do you think you could have a > look? It is very small. Isn't this ABI incompatible change (a

Re: [PING PATCH, PR 57748] Set mode of structures with zero sized arrays to be BLK

2013-08-23 Thread Martin Jambor
Hi Jakub and/or Joseph, the reporter of this bug seems to be very anxious to have it fixed in the repository. While Richi is away, do you think you could have a look? It is very small. Thanks a lot, Martin On Fri, Aug 02, 2013 at 01:45:31PM +0200, Martin Jambor wrote: > Hi, > > while comput

Re: [PATCH, PR 57748] Set mode of structures with zero sized arrays to be BLK

2013-08-20 Thread David Abdurachmanov
ping^2 david On Aug 12, 2013, at 2:31 PM, David Abdurachmanov wrote: > Hi, > > Ping. Any news of the following patch being included into the trunk? > > Thanks, > david > > On Aug 2, 2013, at 1:45 PM, Martin Jambor wrote: > >> Hi, >> >> while compute_record_mode in stor-layout.c makes sure i

Re: [PATCH, PR 57748] Set mode of structures with zero sized arrays to be BLK

2013-08-12 Thread David Abdurachmanov
Hi, Ping. Any news of the following patch being included into the trunk? Thanks, david On Aug 2, 2013, at 1:45 PM, Martin Jambor wrote: > Hi, > > while compute_record_mode in stor-layout.c makes sure it assigns BLK > mode to structs with flexible arrays, it has no such provisions for > zero le

Re: [PATCH, PR 57748] Set mode of structures with zero sized arrays to be BLK

2013-08-12 Thread David Abdurachmanov
Hi, Ping. Any news of the following patch being included into the trunk? Thanks, david On Aug 2, 2013, at 1:45 PM, Martin Jambor wrote: > Hi, > > while compute_record_mode in stor-layout.c makes sure it assigns BLK > mode to structs with flexible arrays, it has no such provisions for > zero le

[PATCH, PR 57748] Set mode of structures with zero sized arrays to be BLK

2013-08-02 Thread Martin Jambor
Hi, while compute_record_mode in stor-layout.c makes sure it assigns BLK mode to structs with flexible arrays, it has no such provisions for zero length arrays (http://gcc.gnu.org/onlinedocs/gcc-4.8.1/gcc/Zero-Length.html). I think that in order to avoid problems and surprises like PR 57748 (wher