Re: [PATCH, PR 54394] Compute loops when generating inline summaries

2012-12-03 Thread H.J. Lu
On Mon, Dec 3, 2012 at 9:50 AM, H.J. Lu wrote: > On Fri, Aug 31, 2012 at 7:41 AM, Martin Jambor wrote: >> Hi, >> >> On Fri, Aug 31, 2012 at 12:06:33PM +0200, Jan Hubicka wrote: >>> > >>> > This is not required to make hints working, it is necessary because of >>> > the following line a in estimat

Re: [PATCH, PR 54394] Compute loops when generating inline summaries

2012-12-03 Thread H.J. Lu
On Fri, Aug 31, 2012 at 7:41 AM, Martin Jambor wrote: > Hi, > > On Fri, Aug 31, 2012 at 12:06:33PM +0200, Jan Hubicka wrote: >> > >> > This is not required to make hints working, it is necessary because of >> > the following line a in estimate_function_body_sizes: >> > >> > es->loop_dept

Re: [PATCH, PR 54394] Compute loops when generating inline summaries

2012-08-31 Thread Martin Jambor
Hi, On Fri, Aug 31, 2012 at 12:06:33PM +0200, Jan Hubicka wrote: > > > > This is not required to make hints working, it is necessary because of > > the following line a in estimate_function_body_sizes: > > > > es->loop_depth = bb_loop_depth (bb); > > > > which always yields zero if we

Re: [PATCH, PR 54394] Compute loops when generating inline summaries

2012-08-31 Thread Jan Hubicka
> > This is not required to make hints working, it is necessary because of > the following line a in estimate_function_body_sizes: > > es->loop_depth = bb_loop_depth (bb); > > which always yields zero if we don't have loops computed. So I can > skip the computation only if we don't

Re: [PATCH, PR 54394] Compute loops when generating inline summaries

2012-08-31 Thread Martin Jambor
On Fri, Aug 31, 2012 at 10:53:32AM +0200, Jan Hubicka wrote: > > Hi, > > > > the patch below fixes PR 54394. The problem is that since revision > > 190346 we depend on bb->loop_father being non-NULL to get loop_depth. > > However, with loops not computed, the loop_father is NULL, loop_depth > > i

Re: [PATCH, PR 54394] Compute loops when generating inline summaries

2012-08-31 Thread Jan Hubicka
> Hi, > > the patch below fixes PR 54394. The problem is that since revision > 190346 we depend on bb->loop_father being non-NULL to get loop_depth. > However, with loops not computed, the loop_father is NULL, loop_depth > is thus considered zero and call graph edges out of such BB can be > consi

[PATCH, PR 54394] Compute loops when generating inline summaries

2012-08-29 Thread Martin Jambor
Hi, the patch below fixes PR 54394. The problem is that since revision 190346 we depend on bb->loop_father being non-NULL to get loop_depth. However, with loops not computed, the loop_father is NULL, loop_depth is thus considered zero and call graph edges out of such BB can be considered much coo