Re: [PATCH, PING*4] PR debug/53927: fix value for DW_AT_static_link

2015-11-26 Thread Pierre-Marie de Rodat
On 11/26/2015 03:50 PM, Eric Botcazou wrote: Here’s the updated patch. Regtested again on x86_64-linux. Thanks, it looks good as far as I'm concerned (modulo the missing "in order" before "not to shift all other offsets" in a comment). Fixed and pushed. Thank you again for reviewing! -- Pier

Re: [PATCH, PING*4] PR debug/53927: fix value for DW_AT_static_link

2015-11-26 Thread Eric Botcazou
> Here’s the updated patch. Regtested again on x86_64-linux. Thanks, it looks good as far as I'm concerned (modulo the missing "in order" before "not to shift all other offsets" in a comment). -- Eric Botcazou

Re: [PATCH, PING*4] PR debug/53927: fix value for DW_AT_static_link

2015-11-26 Thread Pierre-Marie de Rodat
Thank you Jason! On 11/25/2015 09:35 PM, Eric Botcazou wrote: We try to declare variables only at the first use point now I think. Fixed, thanks! + /* Debugging information needs to compute the frame base address of the +nestee frame out of the static chain from the nested frame

Re: [PATCH, PING*4] PR debug/53927: fix value for DW_AT_static_link

2015-11-25 Thread Eric Botcazou
> The DWARF change is OK if the tree-nested.c changes make sense to Eric. As discussed in the audit trail of the PR, I'd rather have avoided the additional indirection, but the DWARF requirement seems to force it if we base the computation on the static chain and I don't see another approach. A

Re: [PATCH, PING*4] PR debug/53927: fix value for DW_AT_static_link

2015-11-25 Thread Jason Merrill
The DWARF change is OK if the tree-nested.c changes make sense to Eric. Jason

Re: [PATCH, PING*4] PR debug/53927: fix value for DW_AT_static_link

2015-11-24 Thread Pierre-Marie de Rodat
On 08/31/2015 09:28 AM, Pierre-Marie de Rodat wrote: Ping for the patch submitted in . As Jason noticed in another thread, I forgot to attach the patch here (although it’s filed in the bug tracker). Here it is! Rebased against trunk, b

[PATCH, PING*4] PR debug/53927: fix value for DW_AT_static_link

2015-08-31 Thread Pierre-Marie de Rodat
On 07/20/2015 09:39 AM, Pierre-Marie de Rodat wrote: This patch fixes the static link description in DWARF to comply with the specification. In order to do so, it appends a field to all FRAME objects to hold the frame base address (DW_AT_frame_base) so that the nested subrograms can directly refe