Re: [PATCH, OpenMP 5.0] Implement structure element mapping changes in 5.0

2020-11-02 Thread Chung-Lin Tang
Thank you Jakub, I'll need some time to look at this. Thanks. Chung-Lin On 2020/10/30 10:05 PM, Jakub Jelinek wrote: On Mon, Oct 26, 2020 at 09:10:08AM +0100, Jakub Jelinek via Gcc-patches wrote: Yes, it is a QoI and it is important not to regress about that. Furthermore, the more we diverge f

Re: [PATCH, OpenMP 5.0] Implement structure element mapping changes in 5.0

2020-10-30 Thread Jakub Jelinek via Gcc-patches
On Mon, Oct 26, 2020 at 09:10:08AM +0100, Jakub Jelinek via Gcc-patches wrote: > Yes, it is a QoI and it is important not to regress about that. > Furthermore, the more we diverge from what the spec says, it will be harder > for us to implement, not just now, but in the future too. > What I wrote a

Re: [PATCH, OpenMP 5.0] Implement structure element mapping changes in 5.0

2020-10-26 Thread Jakub Jelinek via Gcc-patches
On Sat, Oct 24, 2020 at 01:43:26AM +0800, Chung-Lin Tang wrote: > On 2020/10/23 8:13 PM, Jakub Jelinek wrote: > > > In general, upon encountering a construct, we can't statically determine > > > and insert alloc/release maps > > > for each element of a structure variable, since we don't really kno

Re: [PATCH, OpenMP 5.0] Implement structure element mapping changes in 5.0

2020-10-23 Thread Chung-Lin Tang
Hi Jakub, thanks for the prompt review. On 2020/10/23 8:13 PM, Jakub Jelinek wrote: In general, upon encountering a construct, we can't statically determine and insert alloc/release maps for each element of a structure variable, since we don't really know which region of the structure is curre

Re: [PATCH, OpenMP 5.0] Implement structure element mapping changes in 5.0

2020-10-23 Thread Jakub Jelinek via Gcc-patches
On Fri, Oct 23, 2020 at 06:24:20PM +0800, Chung-Lin Tang wrote: > this patch set implements more of OpenMP 5.0 mapping, specifically this part > in 2.19.7.1 map Clause: > > "If a list item in a map clause is a structure element then all other > structure elements of the > containing structure v

[PATCH, OpenMP 5.0] Implement structure element mapping changes in 5.0

2020-10-23 Thread Chung-Lin Tang
Hi Jakub, this patch set implements more of OpenMP 5.0 mapping, specifically this part in 2.19.7.1 map Clause: "If a list item in a map clause is a structure element then all other structure elements of the containing structure variable form a structure sibling list. The map clause and the st