Re: [PATCH, Makefile.in] refine selftest recipes to restore mingw bootstrap

2017-11-28 Thread Olivier Hainque
> On Nov 28, 2017, at 11:56 , Tamar Christina wrote: >> For gcc in particular, ISTM it depends on the target for which you >> configured. > > This is true, but In this case, the tool should have never seen "/dev/null". > Since the invocation > Of the command that uses SELFTEST_FLAGS should hav

RE: [PATCH, Makefile.in] refine selftest recipes to restore mingw bootstrap

2017-11-28 Thread Tamar Christina
TCH, Makefile.in] refine selftest recipes to restore mingw > bootstrap > > Hello Tamar, > > > On Nov 28, 2017, at 11:05 , Tamar Christina > wrote: > > > > Yeah I choose this fix because /dev/null is converted to "nul" by the > > Cygwin/msys2 runti

Re: [PATCH, Makefile.in] refine selftest recipes to restore mingw bootstrap

2017-11-28 Thread Olivier Hainque
Hello Tamar, > On Nov 28, 2017, at 11:05 , Tamar Christina wrote: > > Yeah I choose this fix because /dev/null is converted to "nul" by the > Cygwin/msys2 runtime. So when invoked On the shell it gets converted > before GCC sees it. > > Nothing against using nul directly, though I am surprised

RE: [PATCH, Makefile.in] refine selftest recipes to restore mingw bootstrap

2017-11-28 Thread Tamar Christina
Sending reply to list. > -Original Message- > From: Tamar Christina > Sent: Tuesday, November 28, 2017 10:02 > To: 'David Malcolm' ; Olivier Hainque > ; Jeff Law > Cc: GCC Patches > Subject: RE: [PATCH, Makefile.in] refine selftest recip

Re: [PATCH, Makefile.in] refine selftest recipes to restore mingw bootstrap

2017-11-28 Thread Olivier Hainque
> On Nov 28, 2017, at 07:20 , Jeff Law wrote: >> Given that, I prefer Olivier's patch - it seems simpler to me. > OK. I can live with it. Thanks for for your reviews Jeff and David. Will commit. Windows hosts are full of surprises. It shouldn't be hard to revisit the approach if need be. Wit

Re: [PATCH, Makefile.in] refine selftest recipes to restore mingw bootstrap

2017-11-27 Thread Jeff Law
On 11/27/2017 03:16 PM, David Malcolm wrote: > On Mon, 2017-11-27 at 09:40 +0100, Olivier Hainque wrote: >> (typo in David's email address in the previous message, >> resending. sorry for the duplicates) >> >> Hi Jeff, >> >> (Thanks for your feedback) >> >>> On Nov 27, 2017, at 04:55 , Jeff Law wr

Re: [PATCH, Makefile.in] refine selftest recipes to restore mingw bootstrap

2017-11-27 Thread David Malcolm
On Mon, 2017-11-27 at 09:40 +0100, Olivier Hainque wrote: > (typo in David's email address in the previous message, > resending. sorry for the duplicates) > > Hi Jeff, > > (Thanks for your feedback) > > > On Nov 27, 2017, at 04:55 , Jeff Law wrote: > > > > > * Makefile.in (SELFTEST_FLAGS): U

Re: [PATCH, Makefile.in] refine selftest recipes to restore mingw bootstrap

2017-11-27 Thread Olivier Hainque
(typo in David's email address in the previous message, resending. sorry for the duplicates) Hi Jeff, (Thanks for your feedback) > On Nov 27, 2017, at 04:55 , Jeff Law wrote: > >> * Makefile.in (SELFTEST_FLAGS): Use nul instead of /dev/null >> on mingw build hosts. > Would it make mo

Re: [PATCH, Makefile.in] refine selftest recipes to restore mingw bootstrap

2017-11-27 Thread Olivier Hainque
Hi Jeff, (Thanks for your feedback) > On Nov 27, 2017, at 04:55 , Jeff Law wrote: > >> * Makefile.in (SELFTEST_FLAGS): Use nul instead of /dev/null >> on mingw build hosts. > Would it make more sense to set the output file to HOST_BIT_BUCKET when > -fselftest is active? Hmm, possibl

Re: [PATCH, Makefile.in] refine selftest recipes to restore mingw bootstrap

2017-11-26 Thread Jeff Law
On 11/24/2017 11:18 AM, Olivier Hainque wrote: > Hello, > > Bootstrap for mingw target configurations is failing today, with complaints > about an inexistant /dev/null. > > The failing commands are issued by the selftest recipes in gcc/Makefile, > using: > > SELFTEST_FLAGS = -nostdinc /dev/

[PATCH, Makefile.in] refine selftest recipes to restore mingw bootstrap

2017-11-24 Thread Olivier Hainque
Hello, Bootstrap for mingw target configurations is failing today, with complaints about an inexistant /dev/null. The failing commands are issued by the selftest recipes in gcc/Makefile, using: SELFTEST_FLAGS = -nostdinc /dev/null -S -o /dev/null \ -fself-test=$(srcdir)/testsuite