Re: [PATCH] Fix aarch64 fallout of [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

2016-09-13 Thread Jeff Law
On 09/12/2016 07:43 AM, Bernd Edlinger wrote: Hi, the attached patch boot-straps and reg-tests cleanly on x86_64-pc-linux-gnu, powerpc and aarch64 targets. Is it OK for trunk? Thanks Bernd. patch-pr77289.diff 2016-09-12 Bernd Edlinger PR rtl-optimization/77289 * lra-co

Re: [PATCH] Fix aarch64 fallout of [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

2016-09-12 Thread Bernd Edlinger
On 09/12/16 23:45, Jeff Law wrote: > On 09/12/2016 07:43 AM, Bernd Edlinger wrote: >> Hi, >> >> the attached patch boot-straps and reg-tests cleanly >> on x86_64-pc-linux-gnu, powerpc and aarch64 targets. >> >> Is it OK for trunk? > Unfortunately, there's no explanation for why the original code wa

Re: [PATCH] Fix aarch64 fallout of [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

2016-09-12 Thread Jeff Law
On 09/12/2016 07:43 AM, Bernd Edlinger wrote: Hi, the attached patch boot-straps and reg-tests cleanly on x86_64-pc-linux-gnu, powerpc and aarch64 targets. Is it OK for trunk? Unfortunately, there's no explanation for why the original code was wrong. Yes, I can clearly see you're trying to fi

[PATCH] Fix aarch64 fallout of [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

2016-09-12 Thread Bernd Edlinger
Hi, the attached patch boot-straps and reg-tests cleanly on x86_64-pc-linux-gnu, powerpc and aarch64 targets. Is it OK for trunk? Thanks Bernd. 2016-09-12 Bernd Edlinger PR rtl-optimization/77289 * lra-constraints.c (get_final_hard_regno): Removed. (get_hard_regno): Add new parameter fin

Re: [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

2016-09-12 Thread Kyrill Tkachov
On 11/09/16 21:53, Peter Bergner wrote: On 9/11/16 3:35 PM, Bernd Edlinger wrote: FYI: I have a patch for the aarch64 regression here: https://gcc.gnu.org/bugzilla/attachment.cgi?id=39600 It passes bootstrap and reg-testing on x86_64-linux-gnu. Thanks for debugging and fixing this! Also t

Re: [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

2016-09-11 Thread Peter Bergner
On 9/11/16 3:35 PM, Bernd Edlinger wrote: FYI: I have a patch for the aarch64 regression here: https://gcc.gnu.org/bugzilla/attachment.cgi?id=39600 It passes bootstrap and reg-testing on x86_64-linux-gnu. Thanks for debugging and fixing this! Also the mentioned aarch64 and powerpc test case

Re: [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

2016-09-11 Thread Bernd Edlinger
FYI: I have a patch for the aarch64 regression here: https://gcc.gnu.org/bugzilla/attachment.cgi?id=39600 It passes bootstrap and reg-testing on x86_64-linux-gnu. Also the mentioned aarch64 and powerpc test cases pass manually in a cross-compiler, but I cannot do the boot-strap on powerpc or aarc

Re: [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

2016-09-10 Thread Andrew Pinski
On Fri, Sep 9, 2016 at 6:37 PM, Peter Bergner wrote: > On 9/9/16 5:51 PM, Jeff Law wrote: >> >> On 08/30/2016 10:23 PM, Peter Bergner wrote: >>> >>> gcc/ >>> PR rtl-optimization/77289 >>> * lra-constraints.c (get_final_hard_regno): Add support for non hard >>> register numbers. Remove

Re: [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

2016-09-09 Thread Peter Bergner
On 9/9/16 5:51 PM, Jeff Law wrote: On 08/30/2016 10:23 PM, Peter Bergner wrote: gcc/ PR rtl-optimization/77289 * lra-constraints.c (get_final_hard_regno): Add support for non hard register numbers. Remove support for subregs. (get_hard_regno): Use SUBREG_P. Don't call get_final

Re: [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

2016-09-09 Thread Jeff Law
On 08/30/2016 10:23 PM, Peter Bergner wrote: PR77289 exposes a latent problem with LRA constraint matching. In the buggy test cases, LRA performs a speculative register elimination before checking operands for matching constraints. With the elimination, the operands appear to match. However, w

PING: Re: [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

2016-09-07 Thread Peter Bergner
Ping this patch: https://gcc.gnu.org/ml/gcc-patches/2016-08/msg02099.html Peter

[PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem

2016-08-30 Thread Peter Bergner
PR77289 exposes a latent problem with LRA constraint matching. In the buggy test cases, LRA performs a speculative register elimination before checking operands for matching constraints. With the elimination, the operands appear to match. However, when we call check_rtl() which attempts to recog