Re: [PATCH, Fortran] Wrong invocation of caf_atomic_op

2014-09-22 Thread Alessandro Fanfarillo
Thanks a lot. I'm moving and I didn't have time to make a test case. Regards 2014-09-20 8:14 GMT-06:00 Tobias Burnus : > Hi Alessandro et al., > > I have now committed (Rev. 215421) the attached patch, which includes a test > case for it. > > Thanks for the report and the patch Alessandro! > > Tob

Re: [PATCH, Fortran] Wrong invocation of caf_atomic_op

2014-09-20 Thread Tobias Burnus
Hi Alessandro et al., I have now committed (Rev. 215421) the attached patch, which includes a test case for it. Thanks for the report and the patch Alessandro! Tobias On 15.09.2014 23:29, Tobias Burnus wrote: On 15.09.2014 22:23, Alessandro Fanfarillo wrote: In attachment a test case which

Re: [PATCH, Fortran] Wrong invocation of caf_atomic_op

2014-09-15 Thread Tobias Burnus
On 15.09.2014 22:23, Alessandro Fanfarillo wrote: In attachment a test case which fails with the current gcc-trunk version but works when the patch is applied. coarray_35.f90 is my attempt to write a gcc test case. The problem is related with atomic_add. Well, if it is a "dg-do compile" test, i

Re: [PATCH, Fortran] Wrong invocation of caf_atomic_op

2014-09-15 Thread Alessandro Fanfarillo
In attachment a test case which fails with the current gcc-trunk version but works when the patch is applied. coarray_35.f90 is my attempt to write a gcc test case. The problem is related with atomic_add. 2014-09-15 12:55 GMT-06:00 Tobias Burnus : > On 15.09.2014 19:18, Alessandro Fanfarillo wrote

Re: [PATCH, Fortran] Wrong invocation of caf_atomic_op

2014-09-15 Thread Tobias Burnus
On 15.09.2014 19:18, Alessandro Fanfarillo wrote: New patch after the update. 2014-09-09 0:30 GMT-06:00 Tobias Burnus: >I think I'd prefer the following patch, which avoids a temporary if none is >required. "value" is a pointer if the kind is the same (see kind check >before) and if it is not

Re: [PATCH, Fortran] Wrong invocation of caf_atomic_op

2014-09-15 Thread Alessandro Fanfarillo
New patch after the update. Cheers 2014-09-09 0:30 GMT-06:00 Tobias Burnus : > Alessandro Fanfarillo wrote: >> >> This email follows the previous without subject (sorry about that). > > > I think I'd prefer the following patch, which avoids a temporary if none is > required. "value" is a pointer

Re: [PATCH, Fortran] Wrong invocation of caf_atomic_op

2014-09-08 Thread Tobias Burnus
Alessandro Fanfarillo wrote: This email follows the previous without subject (sorry about that). I think I'd prefer the following patch, which avoids a temporary if none is required. "value" is a pointer if the kind is the same (see kind check before) and if it is not a literal. Otherwise, it

[PATCH, Fortran] Wrong invocation of caf_atomic_op

2014-09-08 Thread Alessandro Fanfarillo
This email follows the previous without subject (sorry about that). The attached patch solves the problem raised by the following code: program atomic use iso_fortran_env implicit none integer :: me integer(atomic_int_kind) :: atom[*] me = this_image() call atomic_define(atom[1],0) sync all call