Re: [PATCH, Fortran, alloc_poly, v2] Fix allocation of memory for polymorphic assignment

2016-12-23 Thread Andre Vehreschild
Hi Janus, hi all, thanks for the review. Committed as r243909. Regards, Andre On Thu, 22 Dec 2016 23:26:19 +0100 Janus Weil wrote: > 2016-12-20 17:07 GMT+01:00 Andre Vehreschild : > > Hi Janus, > > > >> 1) After adding that code block in gfc_trans_assignment_1, it seems > >> like the

Re: [PATCH, Fortran, alloc_poly, v2] Fix allocation of memory for polymorphic assignment

2016-12-22 Thread Janus Weil
2016-12-20 17:07 GMT+01:00 Andre Vehreschild : > Hi Janus, > >> 1) After adding that code block in gfc_trans_assignment_1, it seems >> like the comment above is outdated, right? > > Thanks for noting. > >> 2) Wouldn't it be better to move this block, which does the correct >> allocation for CLASS v

Re: [PATCH, Fortran, alloc_poly, v2] Fix allocation of memory for polymorphic assignment

2016-12-20 Thread Andre Vehreschild
Hi Janus, > 1) After adding that code block in gfc_trans_assignment_1, it seems > like the comment above is outdated, right? Thanks for noting. > 2) Wouldn't it be better to move this block, which does the correct > allocation for CLASS variables, into > "alloc_scalar_allocatable_for_assignment"