Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE

2016-08-09 Thread Jakub Jelinek
On Fri, Jul 29, 2016 at 11:47:18PM +0800, Chung-Lin Tang wrote: > On 2016/7/21 07:13 PM, Jakub Jelinek wrote: > > Better put every && on a separate line if the whole if (...) doesn't fit > > on a single line. > > > >> > + && !n->sym->attr.cray_pointer > >> > +

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE

2016-07-29 Thread Chung-Lin Tang
On 2016/7/21 07:13 PM, Jakub Jelinek wrote: > Better put every && on a separate line if the whole if (...) doesn't fit > on a single line. > >> > +&& !n->sym->attr.cray_pointer >> > +&& !n->sym->attr.cray_pointee) > This is too ugly. I'd instead move the if

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE

2016-07-21 Thread Jakub Jelinek
On Mon, May 09, 2016 at 10:26:50PM +0800, Chung-Lin Tang wrote: > 2015-05-09 Chung-Lin Tang > > gcc/ > * fortran/openmp.c (resolve_omp_clauses): Adjust use_device clause > handling to only allow pointers and arrays. As has been mentioned earlier, this should go into gcc/fortr

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x4)

2016-07-21 Thread Paul Richard Thomas
Hi Chung-Lin, I was ignoring your patch on the grounds that one of the omp gurus should deal with it. That says, it looks OK for trunk to me. I presume that fortran/host_data-1.f90 should have the XFAIL removed? Cheers Paul On 21 July 2016 at 11:28, Chung-Lin Tang wrote: > Ping x4 > > On 201

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x4)

2016-07-21 Thread Chung-Lin Tang
Ping x4 On 2016/7/13 7:52 PM, Chung-Lin Tang wrote: > Ping x3 > > On 06/21/2016 02:18 PM, Chung-Lin Tang wrote: >> Ping x2 >> >> On 2016/6/7 08:03 PM, Chung-Lin Tang wrote: >>> Ping. >>> >>> On 2016/5/11 02:57 AM, Bernhard Reutner-Fischer wrote: On May 9, 2016 4:26:50 PM GMT+02:00, Chung-Lin

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x3)

2016-07-13 Thread Chung-Lin Tang
Ping x3 On 06/21/2016 02:18 PM, Chung-Lin Tang wrote: Ping x2 On 2016/6/7 08:03 PM, Chung-Lin Tang wrote: Ping. On 2016/5/11 02:57 AM, Bernhard Reutner-Fischer wrote: On May 9, 2016 4:26:50 PM GMT+02:00, Chung-Lin Tang wrote: Hi, this patch resolves an ICE for Fortran when using the OpenA

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x2)

2016-06-20 Thread Chung-Lin Tang
Ping x2 On 2016/6/7 08:03 PM, Chung-Lin Tang wrote: > Ping. > > On 2016/5/11 02:57 AM, Bernhard Reutner-Fischer wrote: >> On May 9, 2016 4:26:50 PM GMT+02:00, Chung-Lin Tang >> wrote: >>> Hi, this patch resolves an ICE for Fortran when using the OpenACC >>> host_data directive. Actually, rathe

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE

2016-06-07 Thread Chung-Lin Tang
Ping. On 2016/5/11 02:57 AM, Bernhard Reutner-Fischer wrote: > On May 9, 2016 4:26:50 PM GMT+02:00, Chung-Lin Tang > wrote: >> Hi, this patch resolves an ICE for Fortran when using the OpenACC >> host_data directive. Actually, rather than say resolve, it's more like >> adjusting the front-end t

Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE

2016-05-10 Thread Bernhard Reutner-Fischer
On May 9, 2016 4:26:50 PM GMT+02:00, Chung-Lin Tang wrote: >Hi, this patch resolves an ICE for Fortran when using the OpenACC >host_data directive. Actually, rather than say resolve, it's more like >adjusting the front-end to same middle-end restrictions as C/C++, >namely that we only support po

[PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE

2016-05-09 Thread Chung-Lin Tang
Hi, this patch resolves an ICE for Fortran when using the OpenACC host_data directive. Actually, rather than say resolve, it's more like adjusting the front-end to same middle-end restrictions as C/C++, namely that we only support pointers or arrays for host_data right now. This patch contains a