Re: [PATCH, ARM] Generate conditional compares in Thumb2 state

2011-08-26 Thread Ramana Radhakrishnan
On 19 August 2011 11:06, Ramana Radhakrishnan wrote: >> >> Regression test against cortex-M0/M3/M4 profile with "-mthumb" option >> doesn't show any new failures. > > Please test on ARM state as well and make sure there are no > regressions before committing. > Jiangning told me privately that th

Re: [PATCH, ARM] Generate conditional compares in Thumb2 state

2011-08-19 Thread Ramana Radhakrishnan
> > Regression test against cortex-M0/M3/M4 profile with "-mthumb" option > doesn't show any new failures. Please test on ARM state as well and make sure there are no regressions before committing. Ok if no regressions. Ramana > > Thanks, > -Jiangning

RE: [PATCH, ARM] Generate conditional compares in Thumb2 state

2011-08-17 Thread Jiangning Liu
Attached is the new patch file. Review please! ChangeLog: 2011-08-18 Jiangning Liu * config/arm/arm.md (*ior_scc_scc): Enable for Thumb2 as well. (*ior_scc_scc_cmp): Likewise (*and_scc_scc): Likewise. (*and_scc_scc_cmp): Likewise. (*and_scc_scc_nodom):

RE: [PATCH, ARM] Generate conditional compares in Thumb2 state

2011-08-11 Thread Jiangning Liu
hakrish...@linaro.org] > Sent: Wednesday, August 10, 2011 6:40 PM > To: Jiangning Liu > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH, ARM] Generate conditional compares in Thumb2 state > > On 10 August 2011 09:20, Jiangning Liu wrote: > > PING... > > > > &

Re: [PATCH, ARM] Generate conditional compares in Thumb2 state

2011-08-10 Thread Ramana Radhakrishnan
On 10 August 2011 09:20, Jiangning Liu wrote: > PING... > > BTW, in patch fix_cond_cmp_2.patch, the file mode of thumb2.md is carelessly > changed, so please check attached new patch file fix_cond_cmp_3.patch. > Please do not top post. I've been away for the whole of last week and then been awa

RE: [PATCH, ARM] Generate conditional compares in Thumb2 state

2011-08-10 Thread Jiangning Liu
2011 2:01 PM > To: 'Ramana Radhakrishnan' > Cc: gcc-patches@gcc.gnu.org > Subject: RE: [PATCH, ARM] Generate conditional compares in Thumb2 state > > In attached new patch, arm_arch_thumb2 is changed to TARGET_THUMB2. I > tried that with my patch command line option

RE: [PATCH, ARM] Generate conditional compares in Thumb2 state

2011-08-07 Thread Jiangning Liu
day, August 05, 2011 9:20 AM > To: Jiangning Liu > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH, ARM] Generate conditional compares in Thumb2 state > > On 3 August 2011 08:48, Jiangning Liu wrote: > > This patch is to generate more conditional compare instructions in >

Re: [PATCH, ARM] Generate conditional compares in Thumb2 state

2011-08-05 Thread Ramana Radhakrishnan
> Conversion from it/op/it/op to itt/op/op (and likewise for it/op/ie/op) > seems to be a good fit for a machine-dependent reorg pass. It does happen in cases where you have proper cond-exec patterns. It's final pre-scan that manages this though there is probably a win in doing this before constan

Re: [PATCH, ARM] Generate conditional compares in Thumb2 state

2011-08-05 Thread Paolo Bonzini
On 08/05/2011 03:19 AM, Ramana Radhakrishnan wrote: cmp r0, #43 it ne cmpne r1, #45 it ne movne r0, r1 bx lr [...] there could be a single it block to handle both and thus you could make this even better with cmp r0, #43 i

Re: [PATCH, ARM] Generate conditional compares in Thumb2 state

2011-08-04 Thread Ramana Radhakrishnan
On 3 August 2011 08:48, Jiangning Liu wrote: > This patch is to generate more conditional compare instructions in Thumb2 > state. Given an example like below, > > int f(int i, int j) > { >  if ( (i == '+') || (j == '-') ) { >    return i; >  } else { >    return j; >  } > } > > Without the patch,

[PATCH, ARM] Generate conditional compares in Thumb2 state

2011-08-03 Thread Jiangning Liu
This patch is to generate more conditional compare instructions in Thumb2 state. Given an example like below, int f(int i, int j) { if ( (i == '+') || (j == '-') ) { return i; } else { return j; } } Without the patch, compiler generates the following codes, sub r2, r0,