Re: [PATCH, ARM] Fix line number data for PIC register setup code

2013-10-29 Thread Eric Botcazou
> Reverted on the 4.7 branch. Thanks. -- Eric Botcazou

Re: [PATCH, ARM] Fix line number data for PIC register setup code

2013-10-29 Thread Tom de Vries
On 29/10/13 09:12, Eric Botcazou wrote: >> Updated patch, re-bootstrapped on x86_64 and committed to trunk. >> >> Also applied to 4.7 and 4.8 branches, the same problem is present there. > > You only asked for approval on trunk though, Eric, Sorry about that. > and I'm not sure we really care >

Re: [PATCH, ARM] Fix line number data for PIC register setup code

2013-10-29 Thread Eric Botcazou
> Updated patch, re-bootstrapped on x86_64 and committed to trunk. > > Also applied to 4.7 and 4.8 branches, the same problem is present there. You only asked for approval on trunk though, and I'm not sure we really care about the results of the GDB testsuite on the 4.7 branch at this point, so

Re: [PATCH, ARM] Fix line number data for PIC register setup code

2013-10-28 Thread Tom de Vries
On 27/10/13 17:04, Eric Botcazou wrote: >> The PIC register setup code is emitted after NOTE_INSNS_FUNCTION_BEG, >> because it uses the insert_insn_on_edge mechanism, and the corresponding >> insertion in cfgexpand.c:gimple_expand_cfg takes care to insert the code >> after the parm_birth_insn: >> .

Re: [PATCH, ARM] Fix line number data for PIC register setup code

2013-10-27 Thread Eric Botcazou
> The PIC register setup code is emitted after NOTE_INSNS_FUNCTION_BEG, > because it uses the insert_insn_on_edge mechanism, and the corresponding > insertion in cfgexpand.c:gimple_expand_cfg takes care to insert the code > after the parm_birth_insn: > ... > /* Avoid putting insns befor

[PING] [PATCH, ARM] Fix line number data for PIC register setup code

2013-10-27 Thread Tom de Vries
Ping. Original submission at http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00903.html . This patch fixes a regression of 174 tests in the gdb testsuite for arm-linux-gnueabi with -fPIC (or arm-linux-androideabi) caused by the fix for PR47028. The fix for PR47028 made sure that insertions on the s

Re: [PATCH, ARM] Fix line number data for PIC register setup code

2013-10-14 Thread Tom de Vries
On 14/10/13 00:17, Tom de Vries wrote: > This patch makes sure we emit insertions scheduled for the first real BB > before > NOTE_INSN_FUNCTION_BEG. As a consequence, it moves the PIC register setup code > to before the NOTE_INSN_FUNCTION_BEG. This removes the second .loc, and the > breakpoint of

[PATCH, ARM] Fix line number data for PIC register setup code

2013-10-13 Thread Tom de Vries
Richard, This patch fixes line number data for the PIC register setup code for ARM, resulting in 174 removed FAILs for the gdb testsuite with -fPIC. Consider break.c (minimized from gdb/testsuite/gdb.base/break.c): ... 1 void *v; 2 void a (void *x) { } 3 void b (void) { } 4